Remove new_pr labels when converting PR to draft or closing#2091
Merged
Urgau merged 4 commits intorust-lang:masterfrom Jul 1, 2025
Merged
Remove new_pr labels when converting PR to draft or closing#2091Urgau merged 4 commits intorust-lang:masterfrom
new_pr labels when converting PR to draft or closing#2091Urgau merged 4 commits intorust-lang:masterfrom
Conversation
Kobzol
reviewed
Jun 30, 2025
Member
Kobzol
left a comment
Kobzol
left a comment
There was a problem hiding this comment.
When a PR is converted to draft, the trigger_files autolabelling probably shouldn't be triggered 🤔
Urgau
force-pushed
the
remove-new_pr-labels-when-draft
branch
from
63cbb4c to
0c50534
Compare
Kobzol
reviewed
Jul 1, 2025
Urgau
changed the title
new_pr labels when converting PR to draftnew_pr labels when converting PR to draft or closing
Kobzol
reviewed
Jul 1, 2025
Kobzol
approved these changes
Jul 1, 2025
Member
Kobzol
left a comment
Kobzol
left a comment
There was a problem hiding this comment.
Feel free to merge with/without the rewordings.
Urgau
force-pushed
the
remove-new_pr-labels-when-draft
branch
from
807a8af to
4af2080
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the logic in
[autolabel]to remove thenew_pr = truelabels when a PR is converted to draft or closed. (we re-add them when reopening a pr or marking the pr as ready for review)It doesn't add draft labels (ie
S-waiting-on-draft) but that's pre-existing (opening a draft PR also doesn't add it).Related to #1768 (comment).