Fix <StableSipHasher128 as Hasher>::finish not being platform agnostic#12
Merged
Urgau merged 2 commits intorust-lang:mainfrom Mar 5, 2025
Merged
Fix <StableSipHasher128 as Hasher>::finish not being platform agnostic#12Urgau merged 2 commits intorust-lang:mainfrom
<StableSipHasher128 as Hasher>::finish not being platform agnostic#12Urgau merged 2 commits intorust-lang:mainfrom
Conversation
cuviper
approved these changes
Mar 5, 2025
Member
cuviper
left a comment
cuviper
left a comment
There was a problem hiding this comment.
Looks good, especially adding test coverage, thanks!
I also confirmed that this fixes the cargo test on s390x.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fix
<StableSipHasher128 as Hasher>::finishnot being platform agnostic, found in rust-lang/cargo#15265.I added a test that should hopefully prevent regressions. We do run little and big endian in CI to validate the fix.
It also prepares to release 0.1.2 with the fix.
r? @cuviper