Add secondary stress benchmark for adding trait in owner's trait_map#2436
Open
aerooneqq wants to merge 1 commit intorust-lang:masterfrom
Open
Add secondary stress benchmark for adding trait in owner's trait_map#2436aerooneqq wants to merge 1 commit intorust-lang:masterfrom
trait_map#2436aerooneqq wants to merge 1 commit intorust-lang:masterfrom
Conversation
aerooneqq
force-pushed
the
add-trait-incr-patches
branch
from
5c25208 to
569c00d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new secondary benchmark for case when a new trait is added to
in_scope_traits_mapquery. During experiments with queries in #155678 (where I merged some queries into one, meaning invalidation of any part of the query will invalidate whole new merged query) improvements were reported, however I did not find any benchmark that covered case when a new trait is added toin_scope_traits_mapquery, so I can not fully trust those results.A real-life scenario where such regression is possible is importing (or creating) a new trait with functions whose names are mentioned frequently in a file in a deferred typecheck context.
cc @petrochenkov