`dlltool`: Set the working directory to workaround `--temp-prefix` bug by ChrisDenton · Pull Request #155899 · rust-lang/rust

ChrisDenton · 2026-04-28T02:50:22Z

dlltool's --temp-prefix argument incorrectly splits paths that contain spaces. To workaround this, we pass a relative path to --temp-prefix and set the working directory.

fixes #155591

rustbot · 2026-04-28T02:50:27Z

r? @eholk

rustbot has assigned @eholk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: codegen, compiler
codegen, compiler expanded to 73 candidates
Random selection from 20 candidates

mati865

Thanks! That Binutils bug looks really cursed.

@bors r+

View changes since this review

rust-bors · 2026-04-28T08:58:36Z

📌 Commit f5c39ef has been approved by mati865

It is now in the queue for this repository.

mati865 · 2026-04-28T09:01:10Z

Nominating for beta backport: this PR fixes compilation on Tier 1 target when the output directory path contains spaces.

lqd · 2026-04-28T09:01:48Z

is it possible to add a test? the issue seems to be on stable already, right? if so, do you think this PR be stable nominated as well?

`dlltool`: Set the working directory to workaround `--temp-prefix` bug dlltool's `--temp-prefix` argument incorrectly splits paths that contain spaces. To workaround this, we pass a relative path to `--temp-prefix` and set the working directory. fixes rust-lang#155591

rust-bors · 2026-04-28T09:36:07Z

⚠️ A new commit f0b095068a8d38f5b76888189a16a247a19bb03a was pushed.

This pull request was unapproved.

This PR was contained in a rollup (#155908), which was closed.

ChrisDenton · 2026-04-28T09:38:33Z

is it possible to add a test?

I've added a run-make test that tries building a raw-dylib library with an output path and a temp directory that contains spaces.

And oops, I just noticed this was already in rollup, sorry!

mati865 · 2026-04-28T12:24:47Z

is it possible to add a test? the issue seems to be on stable already, right? if so, do you think this PR be stable nominated as well?

Honestly, I don't know if this is common enough to make us do a patch release. If 1.95.1 was already expected to happen, this surely would be a candidate to including.

I've added a run-make test that tries building a raw-dylib library with an output path and a temp directory that contains spaces.

Oh, this is much simpler than I expected. Gotta love the new run-make tests infra!

@bors r+

rust-bors · 2026-04-28T12:24:56Z

📌 Commit f0b0950 has been approved by mati865

It is now in the queue for this repository.

apiraino · 2026-04-28T13:54:23Z

Honestly, I don't know if this is common enough to make us do a patch release. If 1.95.1 was already expected to happen, this surely would be a candidate to including.

I'll nominate and then we'll see when the times comes. AFAIK so far there are no plans for a dot release (but that might change)

@rustbot label stable-nominated

`dlltool`: Set the working directory to workaround `--temp-prefix` bug dlltool's `--temp-prefix` argument incorrectly splits paths that contain spaces. To workaround this, we pass a relative path to `--temp-prefix` and set the working directory. fixes rust-lang#155591

…uwer Rollup of 12 pull requests Successful merges: - #151994 (switch to v0 mangling by default on stable) - #154325 (Tweak irrefutable let else warning output) - #155899 (`dlltool`: Set the working directory to workaround `--temp-prefix` bug) - #155273 (Lock stable_crate_ids once in create_crate_num) - #155361 (Document that CFI diverges from Rust wrt. ABI-compatibility rules) - #155692 (disable naked-dead-code-elimination test if no RET mnemonic is available) - #155747 (Update documentation for `wasm32-wali-linux-musl` after integrating n…) - #155768 (compiletest: Overhaul the code for running an incremental test revision) - #155907 (Handle hkl const closures) - #155910 (misc stuff from reading borrowck again :)) - #155913 (Delete the 12 year old fixme) - #155920 (remove review queue triagebot mentions)

`dlltool`: Set the working directory to workaround `--temp-prefix` bug dlltool's `--temp-prefix` argument incorrectly splits paths that contain spaces. To workaround this, we pass a relative path to `--temp-prefix` and set the working directory. fixes rust-lang#155591

JonathanBrouwer · 2026-04-28T18:23:45Z

@bors r-
#155933 (comment)

rust-bors · 2026-04-28T18:23:53Z

This pull request was unapproved.

This PR was contained in a rollup (#155937), which was unapproved.

View changes since this unapproval

`dlltool`: Set the working directory to workaround `--temp-prefix` bug try-job: x86_64-mingw-1

ChrisDenton · 2026-04-29T00:17:50Z

@bors try jobs=x86_64-mingw-1

`dlltool`: Set the working directory to workaround `--temp-prefix` bug try-job: x86_64-mingw-1

rust-bors · 2026-04-29T03:16:24Z

☀️ Try build successful (CI)
Build commit: b3bb1c5 (b3bb1c56e4de0de35817df92ba54539b0d85f09a, parent: 37d85e592f9ae5f20f7d9a9f99785246fa7298da)

ChrisDenton · 2026-04-29T03:26:27Z

All test output should be properly blessed and working now, sorry for the noise.

@bors r=mati865

rust-bors · 2026-04-29T03:26:30Z

📌 Commit 6d20c98 has been approved by mati865

It is now in the queue for this repository.

`dlltool`: Set the working directory to workaround `--temp-prefix` bug dlltool's `--temp-prefix` argument incorrectly splits paths that contain spaces. To workaround this, we pass a relative path to `--temp-prefix` and set the working directory. fixes rust-lang#155591

rustbot assigned eholk Apr 28, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 28, 2026

ChrisDenton changed the title ~~dlltool: Set the working directory to workaround --temp-prefix~~ dlltool: Set the working directory to workaround --temp-prefix bug Apr 28, 2026

mati865 approved these changes Apr 28, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 28, 2026

mati865 added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 28, 2026

jhpratt mentioned this pull request Apr 28, 2026

Rollup of 8 pull requests #155908

Closed

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 28, 2026

rustbot added the A-run-make Area: port run-make Makefiles to rmake.rs label Apr 28, 2026

This comment was marked as outdated.

Sign in to view

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 28, 2026

rustbot added the stable-nominated Nominated for backporting to the compiler in the stable channel. label Apr 28, 2026

JonathanBrouwer mentioned this pull request Apr 28, 2026

Rollup of 12 pull requests #155933

Closed

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 28, 2026

ChrisDenton force-pushed the dlltool branch from f0b0950 to b0fcc76 Compare April 28, 2026 18:32

This comment was marked as outdated.

Sign in to view