Shrink ParseSess#155896
Open
nnethercote wants to merge 2 commits intorust-lang:mainfrom
Open
Conversation
Collaborator
|
Some changes occurred in compiler/rustc_attr_parsing cc @jdonszelmann, @JonathanBrouwer Some changes occurred to diagnostic attributes. cc @mejrs Some changes occurred in check-cfg diagnostics cc @Urgau |
rustbot
added
A-attributes
JonathanBrouwer
approved these changes
Apr 28, 2026
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
- This field is just a copy of `sess.unstable_opts.assume_incomplete_release`. - This field has a single use. - `sess` is also available at that use point So this commit removes the field and gets the value directly from `sess`.
`ParseSess` is separate from, but sits within, `Session`. The separation is because there are some places (e.g. `Parser` methods) where `ParseSess` is available but `Session` is not. However, `ParseSess` has four fields that are only accessed from places where `Session` is also available. This commit moves those fields to `Session`. This means that `ParseSess` only contains the fields it genuinely needs, and various `sess.psess.foo` occurrences are reduced to `sess.foo`.
nnethercote
force-pushed
the
shrink-ParseSess
branch
from
624fb95 to
01e933f
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
|
I rebased. @bors r=JonathanBrouwer |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
ShoyuVanilla
added a commit
to ShoyuVanilla/rust
that referenced
this pull request
Apr 29, 2026
…nathanBrouwer Shrink `ParseSess` `ParseSess` contains some unnecessary fields. Details in individual commits. r? @JonathanBrouwer
rust-bors Bot
pushed a commit
that referenced
this pull request
Apr 29, 2026
Rollup of 6 pull requests Successful merges: - #152443 (NVPTX: Drop support for old architectures and old ISAs) - #155648 (`-Znext-solver` Propagate `stalled_on_coroutines` as a field in `Certainty::Maybe`) - #155896 (Shrink `ParseSess`) - #155922 (delete unused auxiliary test files) - #155943 (fix: ✏️ forgot to change the stable version for `assert_matches!` macro.) - #155947 (tests: mark simple UI tests as check-pass)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ParseSesscontains some unnecessary fields. Details in individual commits.r? @JonathanBrouwer