Improve emission of `UnknownDiagnosticAttribute` lint by mejrs · Pull Request #155174 · rust-lang/rust

mejrs · 2026-04-11T23:52:54Z

This checks features much less than the current implementation. See #155155 for context. Minor fixes and comments are added in the second and third commit.

…eature gate

…each other

rustbot · 2026-04-11T23:53:01Z

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

rustbot · 2026-04-11T23:53:03Z

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 69 candidates
Random selection from 11 candidates

Kivooeo · 2026-04-12T00:00:37Z

@bors try @rust-timer queue

Improve emission of `UnknownDiagnosticAttribute` lint

rust-bors · 2026-04-12T02:13:58Z

☀️ Try build successful (CI)
Build commit: f7ca6d3 (f7ca6d3c3bc1892c18067d811d5ffafe07f59ada, parent: bf4fbfb7a18d74e7cd8eef93af7329c58fbb5344)

rust-timer · 2026-04-12T02:54:18Z

Finished benchmarking commit (f7ca6d3): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (secondary -5.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-5.8%	[-5.8%, -5.8%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results (primary -6.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-6.2%	[-9.0%, -1.8%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-6.2%	[-9.0%, -1.8%]	3

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 490.796s -> 491.972s (0.24%)
Artifact size: 394.14 MiB -> 394.19 MiB (0.01%)

rustbot · 2026-04-12T11:24:41Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

mejrs · 2026-04-12T16:46:09Z

@rustbot ready

JonathanBrouwer · 2026-04-12T17:39:41Z

@bors r+ rollup

rust-bors · 2026-04-12T17:39:45Z

📌 Commit 08a12dc has been approved by JonathanBrouwer

It is now in the queue for this repository.

…ouwer Improve emission of `UnknownDiagnosticAttribute` lint This checks features much less than the current implementation. See rust-lang#155155 for context. Minor fixes and comments are added in the second and third commit.

…uwer Rollup of 4 pull requests Successful merges: - #155162 (relnotes for 1.95) - #154193 (Implement EII for statics) - #154435 (resolve: Some import resolution cleanups) - #155174 (Improve emission of `UnknownDiagnosticAttribute` lint)

…ouwer Improve emission of `UnknownDiagnosticAttribute` lint This checks features much less than the current implementation. See rust-lang#155155 for context. Minor fixes and comments are added in the second and third commit.

…uwer Rollup of 6 pull requests Successful merges: - #155162 (relnotes for 1.95) - #154049 (delegation: Track more precise spans for glob delegations) - #154193 (Implement EII for statics) - #154435 (resolve: Some import resolution cleanups) - #154624 (Make `DerefPure` dyn-incompatible) - #155174 (Improve emission of `UnknownDiagnosticAttribute` lint)

…ouwer Improve emission of `UnknownDiagnosticAttribute` lint This checks features much less than the current implementation. See rust-lang#155155 for context. Minor fixes and comments are added in the second and third commit.

…uwer Rollup of 13 pull requests Successful merges: - #155162 (relnotes for 1.95) - #140763 (Change codegen of LLVM intrinsics to be name-based, and add llvm linkage support for `bf16(xN)` and `i1xN`) - #154049 (delegation: Track more precise spans for glob delegations) - #154193 (Implement EII for statics) - #154435 (resolve: Some import resolution cleanups) - #153941 (tests/debuginfo/basic-stepping.rs: Explain why all lines are not steppable) - #154587 (Add --verbose-run-make-subprocess-output flag to suppress verbose run-make output for passing tests) - #154624 (Make `DerefPure` dyn-incompatible) - #154929 (Add `const Default` impls for `LazyCell` and `LazyLock`) - #154944 (Small refactor of `arena_cache` query values) - #155131 (Stabilize feature `uint_bit_width`) - #155147 (Stabilize feature `int_lowest_highest_one`) - #155174 (Improve emission of `UnknownDiagnosticAttribute` lint)

…ouwer Improve emission of `UnknownDiagnosticAttribute` lint This checks features much less than the current implementation. See rust-lang#155155 for context. Minor fixes and comments are added in the second and third commit.

…uwer Rollup of 19 pull requests Successful merges: - #155162 (relnotes for 1.95) - #140763 (Change codegen of LLVM intrinsics to be name-based, and add llvm linkage support for `bf16(xN)` and `i1xN`) - #153604 (Fix thread::available_parallelism on WASI targets with threads) - #154193 (Implement EII for statics) - #154389 (Add more robust handling of nested query cycles) - #154435 (resolve: Some import resolution cleanups) - #155236 (Normalize individual predicate of `InstantiatedPredicates` inside `predicates_for_generics`) - #155243 (cg_ssa: transmute between scalable vectors) - #153941 (tests/debuginfo/basic-stepping.rs: Explain why all lines are not steppable) - #154587 (Add --verbose-run-make-subprocess-output flag to suppress verbose run-make output for passing tests) - #154624 (Make `DerefPure` dyn-incompatible) - #154929 (Add `const Default` impls for `LazyCell` and `LazyLock`) - #154944 (Small refactor of `arena_cache` query values) - #155055 (UI automation) - #155062 (Move tests from `tests/ui/issues/` to appropriate directories) - #155131 (Stabilize feature `uint_bit_width`) - #155147 (Stabilize feature `int_lowest_highest_one`) - #155174 (Improve emission of `UnknownDiagnosticAttribute` lint) - #155194 (Fix manpage version replacement and use verbose version)

Rollup merge of #155174 - mejrs:on_move_gating, r=JonathanBrouwer Improve emission of `UnknownDiagnosticAttribute` lint This checks features much less than the current implementation. See #155155 for context. Minor fixes and comments are added in the second and third commit.

…uwer Rollup of 19 pull requests Successful merges: - rust-lang/rust#155162 (relnotes for 1.95) - rust-lang/rust#140763 (Change codegen of LLVM intrinsics to be name-based, and add llvm linkage support for `bf16(xN)` and `i1xN`) - rust-lang/rust#153604 (Fix thread::available_parallelism on WASI targets with threads) - rust-lang/rust#154193 (Implement EII for statics) - rust-lang/rust#154389 (Add more robust handling of nested query cycles) - rust-lang/rust#154435 (resolve: Some import resolution cleanups) - rust-lang/rust#155236 (Normalize individual predicate of `InstantiatedPredicates` inside `predicates_for_generics`) - rust-lang/rust#155243 (cg_ssa: transmute between scalable vectors) - rust-lang/rust#153941 (tests/debuginfo/basic-stepping.rs: Explain why all lines are not steppable) - rust-lang/rust#154587 (Add --verbose-run-make-subprocess-output flag to suppress verbose run-make output for passing tests) - rust-lang/rust#154624 (Make `DerefPure` dyn-incompatible) - rust-lang/rust#154929 (Add `const Default` impls for `LazyCell` and `LazyLock`) - rust-lang/rust#154944 (Small refactor of `arena_cache` query values) - rust-lang/rust#155055 (UI automation) - rust-lang/rust#155062 (Move tests from `tests/ui/issues/` to appropriate directories) - rust-lang/rust#155131 (Stabilize feature `uint_bit_width`) - rust-lang/rust#155147 (Stabilize feature `int_lowest_highest_one`) - rust-lang/rust#155174 (Improve emission of `UnknownDiagnosticAttribute` lint) - rust-lang/rust#155194 (Fix manpage version replacement and use verbose version)

mejrs added 3 commits April 12, 2026 01:24

Lazily check diagnostic namespace features

21925e9

Properly emit diagnostic for diagnostic::on_move being used without f…

d69403a

…eature gate

Change edit distance to not suggest on_move and on_const against …

55cd476

…each other

mejrs marked this pull request as ready for review April 11, 2026 23:52

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 11, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 11, 2026

rustbot assigned nnethercote Apr 11, 2026

mejrs mentioned this pull request Apr 11, 2026

Reduce size of ImportData #155167

Merged

This comment has been minimized.

Sign in to view

rust-bors bot pushed a commit that referenced this pull request Apr 12, 2026

Auto merge of #155174 - mejrs:on_move_gating, r=<try>

f7ca6d3

Improve emission of `UnknownDiagnosticAttribute` lint

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 12, 2026

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 12, 2026

JonathanBrouwer reviewed Apr 12, 2026

View reviewed changes

Comment thread tests/ui/feature-gates/feature-gate-diagnostic-on-move.rs

JonathanBrouwer requested changes Apr 12, 2026

View reviewed changes

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 12, 2026

rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 12, 2026

Add feature hint for unstable diagnostic attributes

08a12dc

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 12, 2026

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 12, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 12, 2026

JonathanBrouwer mentioned this pull request Apr 12, 2026

Rollup of 3 pull requests #155205

Closed

JonathanBrouwer mentioned this pull request Apr 12, 2026

Rollup of 3 pull requests #155208

Closed

JonathanBrouwer mentioned this pull request Apr 12, 2026

Rollup of 4 pull requests #155212

Closed

JonathanBrouwer mentioned this pull request Apr 12, 2026

Rollup of 6 pull requests #155214

Closed

JonathanBrouwer mentioned this pull request Apr 13, 2026

Rollup of 13 pull requests #155225

Closed

This was referenced Apr 13, 2026

Rollup of 20 pull requests #155245

Closed

Rollup of 19 pull requests #155253

Merged

rust-bors bot merged commit e3d1d77 into rust-lang:main Apr 13, 2026
11 checks passed

rustbot added this to the 1.97.0 milestone Apr 13, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Improve emission of `UnknownDiagnosticAttribute` lint#155174

Improve emission of `UnknownDiagnosticAttribute` lint#155174
rust-bors[bot] merged 4 commits intorust-lang:mainfrom
mejrs:on_move_gating

mejrs commented Apr 11, 2026

Uh oh!

rustbot commented Apr 11, 2026

Uh oh!

rustbot commented Apr 11, 2026

Uh oh!

Kivooeo commented Apr 12, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors bot commented Apr 12, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Apr 12, 2026

Uh oh!

Uh oh!

rustbot commented Apr 12, 2026

Uh oh!

mejrs commented Apr 12, 2026

Uh oh!

JonathanBrouwer commented Apr 12, 2026

Uh oh!

rust-bors bot commented Apr 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

mejrs commented Apr 11, 2026

Uh oh!

rustbot commented Apr 11, 2026

Uh oh!

rustbot commented Apr 11, 2026

Uh oh!

Kivooeo commented Apr 12, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors bot commented Apr 12, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Apr 12, 2026

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!

rustbot commented Apr 12, 2026

Uh oh!

mejrs commented Apr 12, 2026

Uh oh!

JonathanBrouwer commented Apr 12, 2026

Uh oh!

rust-bors bot commented Apr 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants