Open
Conversation
rustbot
added
A-LLVM
This comment has been minimized.
This comment has been minimized.
rustbot
added
S-waiting-on-review
Member
ZuseZ4
reviewed
Apr 15, 2026
| builder.store(geps[i as usize], gep2, Align::EIGHT); | ||
|
|
||
| if matches!(metadata[i as usize].payload_size, OffloadSize::Dynamic) { | ||
| if matches!(metadata[i as usize].payload_size, OffloadSize::Dynamic(_)) { |
Member
There was a problem hiding this comment.
Try if let OffloadSize::Dynamic(dynamic_size: DynamicSize) = metadata[i as usize].payload_size {
and update the get_runtime_size below, so we don't have more unnecessary matches.
ZuseZ4
reviewed
Apr 15, 2026
| pub enum OffloadSize { | ||
| Dynamic, | ||
| Static(u64), | ||
| Dynamic(DynamicSize), |
Member
There was a problem hiding this comment.
I'd probably for now directly add Slice under OffloadSize, at least until we handle more dynamic ones.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows offload to support slice type arguments.
NOTE: this is built on top of #152283r? @ZuseZ4