Skip to content

Port lint attributes to attribute parser #152369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rust-bors merged 11 commits into from
Apr 3, 2026
Merged

Port lint attributes to attribute parser #152369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3f34c31
add variant `ExpectedNameValueAsLastArgument` to `AttributeParseError…
Bryntet Feb 22, 2026
4ab05bc
make tools on `AttributeParser` hold reference to `RegisteredTools`
Bryntet Mar 4, 2026
5816802
add field `attr_id` to attr parser's `AcceptContext`
Bryntet Feb 22, 2026
0fa6b55
Decouple `CheckLintNameResult` from `rustc_lint`
Bryntet Mar 4, 2026
cd88c39
make lint_index mandatory in `LintExpectationId`
Bryntet Feb 22, 2026
345a3eb
Port `#[allow]`, `#[deny]`, `#[expect]`, `#[forbid]`, `#[warn]` to at…
Bryntet Mar 10, 2026
d884f92
integrate parsed lint attrs into clippy
Bryntet Feb 22, 2026
bd864ef
bless tests and tidy
Bryntet Mar 10, 2026
bcebd2c
don't parse attributes in pre-expansion lints
Bryntet Feb 24, 2026
852df88
deduplicate unused expect lints
Bryntet Mar 4, 2026
ce7c492
fix rebase
JonathanBrouwer Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Cargo.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4224,7 +4224,6 @@ dependencies = [
name = "rustc_lint_defs"
version = "0.0.0"
dependencies = [
"rustc_ast",
"rustc_data_structures",
"rustc_error_messages",
"rustc_hir_id",
Expand Down
2 changes: 1 addition & 1 deletion compiler/rustc_ast_lowering/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ struct LoweringContext<'a, 'hir, R> {

impl<'a, 'hir, R: ResolverAstLoweringExt<'hir>> LoweringContext<'a, 'hir, R> {
fn new(tcx: TyCtxt<'hir>, resolver: &'a mut R) -> Self {
let registered_tools = tcx.registered_tools(()).iter().map(|x| x.name).collect();
let registered_tools = tcx.registered_tools(());
Self {
tcx,
resolver,
Expand Down
7 changes: 6 additions & 1 deletion compiler/rustc_attr_parsing/src/attributes/codegen_attrs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,10 +295,15 @@ impl<S: Stage> AttributeParser<S> for NakedParser {

let span = self.span?;

let Some(tools) = cx.tools else {
unreachable!("tools required while parsing attributes");
};

let tools = tools.iter().map(|tool| tool.name).collect::<Vec<_>>();
Copy link
Copy Markdown
Contributor

@cjgillot cjgillot Mar 5, 2026 •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

View changes since the review

Do we really need to collect here, or could we change the tools.contains check below to use cx.tools directly?

// only if we found a naked attribute do we do the somewhat expensive check
'outer: for other_attr in cx.all_attrs {
for allowed_attr in ALLOW_LIST {
if other_attr.segments().next().is_some_and(|i| cx.tools.contains(&i.name)) {
if other_attr.segments().next().is_some_and(|i| tools.contains(&i.name)) {
// effectively skips the error message being emitted below
// if it's a tool attribute
continue 'outer;
Expand Down
Loading
Loading