Skip to content

rustdoc: sort stable items first#149460

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
lolbinarycat:rustdoc-search-sort-stable-first
Feb 14, 2026
Merged

rustdoc: sort stable items first#149460
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
lolbinarycat:rustdoc-search-sort-stable-first

Conversation

@lolbinarycat
Copy link
Copy Markdown
Contributor

@lolbinarycat lolbinarycat commented Nov 29, 2025

Finally tackling this again now that the search system refactor is done. The tests and the general approach were taken from the original PR.

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Nov 29, 2025

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @lolbinarycat

@rustbot rustbot added the A-rustdoc-search Area: Rustdoc's search feature label Nov 29, 2025
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Nov 29, 2025
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Nov 29, 2025

r? @notriddle

rustbot has assigned @notriddle.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@lolbinarycat lolbinarycat mentioned this pull request Nov 29, 2025
Open
@rust-log-analyzer

This comment has been minimized.

Sign in to view
notriddle
notriddle reviewed Nov 29, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@notriddle notriddle left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A simple nit pick, but I think the release team would dislike a PR title that's backwards from the actual behavior.

The implementation itself seems okay.

View changes since this review

Comment thread tests/rustdoc-js/sort-stability.js
Copy link
Copy Markdown
Contributor

@notriddle notriddle Nov 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title says it sorts unstable items first. This test seems to show the unstable item appearing last. Which is it?

Copy link
Copy Markdown
Contributor Author

@lolbinarycat lolbinarycat Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr title was a typo, fixed (need to go back and fix the commit description too)

GuillaumeGomez
GuillaumeGomez reviewed Nov 30, 2025
View reviewed changes
Comment thread src/librustdoc/html/static/js/search.js
return a - b;
}

// sort unstable items later
Copy link
Copy Markdown
Member

@GuillaumeGomez GuillaumeGomez Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That confirms that title is wrong. 😉

@lolbinarycat lolbinarycat changed the title rustdoc: sort unstable items first rustdoc: sort stable items first Nov 30, 2025
@rust-bors

This comment has been minimized.

Sign in to view
@lolbinarycat lolbinarycat force-pushed the rustdoc-search-sort-stable-first branch from 0a9a15a to 22ac5f7 Compare January 28, 2026 17:30
@rustbot rustbot added the A-rustdoc-js Area: Rustdoc's JS front-end label Jan 28, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Jan 28, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@lolbinarycat lolbinarycat mentioned this pull request Feb 13, 2026
Open
@lolbinarycat lolbinarycat force-pushed the rustdoc-search-sort-stable-first branch from 22ac5f7 to dca86a9 Compare February 13, 2026 20:43
@notriddle
Copy link
Copy Markdown
Contributor

notriddle commented Feb 14, 2026

@bors r+

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Feb 14, 2026

📌 Commit dca86a9 has been approved by notriddle

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 14, 2026
@jhpratt jhpratt mentioned this pull request Feb 14, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Feb 14, 2026
@bors
Auto merge of #152602 - jhpratt:rollup-uaxGseW, r=jhpratt
3f808f2 
Rollup of 11 pull requests

Successful merges:

 - #151998 (Set hidden visibility on naked functions in compiler-builtins)
 - #149460 (rustdoc: sort stable items first)
 - #152076 (Feed `ErrorGuaranteed` from late lifetime resolution errors through to bound variable resolution)
 - #152471 (improve associated-type suggestions from bounds)
 - #152573 (move `escape_symbol_name` to `cg_ssa`)
 - #152594 (c-variadic: implement `va_arg` for `wasm64`)
 - #151386 (rustdoc: more js cleanup)
 - #152567 (nix-dev-shell: fix a typo)
 - #152568 (Port `#[lang]` and `#[panic_handler]` to the new attribute parsers)
 - #152575 (layout_of unexpected rigid alias delayed bug)
 - #152587 (A couple of tiny polonius things)
@rust-bors rust-bors bot merged commit 9b4219b into rust-lang:main Feb 14, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Feb 14, 2026
rust-timer added a commit that referenced this pull request Feb 14, 2026
@rust-timer
Unrolled build for #149460
e4020e0 
Rollup merge of #149460 - lolbinarycat:rustdoc-search-sort-stable-first, r=notriddle

rustdoc: sort stable items first

Finally tackling this again now that the search system refactor is done.  The tests and the general approach were taken from the original PR.
@lolbinarycat lolbinarycat added the relnotes Marks issues that should be documented in the release notes of the next release. label Feb 14, 2026
@rustbot rustbot mentioned this pull request Feb 14, 2026
Closed
@BoxyUwU BoxyUwU mentioned this pull request Apr 2, 2026
Closed
wip-sync pushed a commit to NetBSD/pkgsrc-wip that referenced this pull request Apr 16, 2026
@he32
rust195: Add a package for rust 1.95.0.
f217087 
Pkgsrc changes:
 * Update version & checksums, and adapt to new libc crate included.

Upstream changes relative to 1.94.1:

Version 1.95 (2026-04-16)
==========================

Language
--------
- [Stabilize `if let` guards on match arms]
  (rust-lang/rust#141295)
- [`irrefutable_let_patterns` lint no longer lints on let chains]
  (rust-lang/rust#146832)
- [Support importing path-segment keywords with renaming]
  (rust-lang/rust#146972)
- [Stabilize inline assembly for PowerPC and PowerPC64]
  (rust-lang/rust#147996)
- [const-eval: be more consistent in the behavior of padding during
  typed copies] (rust-lang/rust#148967)
- [Const blocks are no longer evaluated to determine if expressions
  involving fallible operations can implicitly be constant-promoted.]
  (rust-lang/rust#150557). Expressions
  whose ability to implicitly be promoted would depend on the result
  of a const block are no longer implicitly promoted.
- [Make operational semantics of pattern matching independent of
  crate and module] (rust-lang/rust#150681)

Compiler
--------
- [Stabilize `--remap-path-scope` for controlling the scoping of
  how paths get remapped in the resulting binary]
  (rust-lang/rust#147611)

Platform Support
----------------
- [Promote `powerpc64-unknown-linux-musl` to Tier 2 with host tools]
  (rust-lang/rust#149962)
- [Promote `aarch64-apple-tvos` to Tier 2]
  (rust-lang/rust#152021)
- [Promote `aarch64-apple-tvos-sim` to Tier 2]
  (rust-lang/rust#152021)
- [Promote `aarch64-apple-watchos` to Tier 2]
  (rust-lang/rust#152021)
- [Promote `aarch64-apple-watchos-sim` to Tier 2]
  (rust-lang/rust#152021)
- [Promote `aarch64-apple-visionos` to Tier 2]
  (rust-lang/rust#152021)
- [Promote `aarch64-apple-visionos-sim` to Tier 2]
  (rust-lang/rust#152021)

Refer to Rust's [platform support page][platform-support-doc]
for more information on Rust's tiered platform support.

https://doc.rust-lang.org/rustc/platform-support.html

Libraries
---------
- [`thread::scope`: document how join interacts with TLS destructors]
  (rust-lang/rust#149482)
- [Speed up `str::contains` on aarch64 targets with `neon` target
  feature enabled by default]
  (rust-lang/rust#152176)

Stabilized APIs
---------------

- [`MaybeUninit<[T; N]>: From<[MaybeUninit<T>; N]>`]
  (https://doc.rust-lang.org/stable/std/mem/union.MaybeUninit.html#impl-From%3CMaybeUninit%3C%5BT;+N%5D%3E%3E-for-%5BMaybeUninit%3CT%3E;+N%5D)
- [`MaybeUninit<[T; N]>: AsRef<[MaybeUninit<T>; N]>`]
  (https://doc.rust-lang.org/stable/std/mem/union.MaybeUninit.html#impl-AsRef%3C%5BMaybeUninit%3CT%3E;+N%5D%3E-for-MaybeUninit%3C%5BT;+N%5D%3E)
- [`MaybeUninit<[T; N]>: AsRef<[MaybeUninit<T>]>`]
  (https://doc.rust-lang.org/stable/std/mem/union.MaybeUninit.html#impl-AsRef%3C%5BMaybeUninit%3CT%3E%5D%3E-for-MaybeUninit%3C%5BT;+N%5D%3E)
- [`MaybeUninit<[T; N]>: AsMut<[MaybeUninit<T>; N]>`]
  (https://doc.rust-lang.org/beta/std/mem/union.MaybeUninit.html#impl-AsMut%3C%5BMaybeUninit%3CT%3E;+N%5D%3E-for-MaybeUninit%3C%5BT;+N%5D%3E)
- [`MaybeUninit<[T; N]>: AsMut<[MaybeUninit<T>]>`]
  (https://doc.rust-lang.org/stable/std/mem/union.MaybeUninit.html#impl-AsMut%3C%5BMaybeUninit%3CT%3E%5D%3E-for-MaybeUninit%3C%5BT;+N%5D%3E)
- [`[MaybeUninit<T>; N]: From<MaybeUninit<[T; N]>>`]
  (https://doc.rust-lang.org/stable/std/mem/union.MaybeUninit.html#impl-From%3C%5BMaybeUninit%3CT%3E;+N%5D%3E-for-MaybeUninit%3C%5BT;+N%5D%3E)
- [`Cell<[T; N]>: AsRef<[Cell<T>; N]>`]
  (https://doc.rust-lang.org/stable/std/cell/struct.Cell.html#impl-AsRef%3C%5BCell%3CT%3E;+N%5D%3E-for-Cell%3C%5BT;+N%5D%3E)
- [`Cell<[T; N]>: AsRef<[Cell<T>]>`]
  (https://doc.rust-lang.org/stable/std/cell/struct.Cell.html#impl-AsRef%3C%5BCell%3CT%3E%5D%3E-for-Cell%3C%5BT;+N%5D%3E)
- [`Cell<[T]>: AsRef<[Cell<T>]>`]
  (https://doc.rust-lang.org/stable/std/cell/struct.Cell.html#impl-AsRef%3C%5BCell%3CT%3E%5D%3E-for-Cell%3C%5BT%5D%3E)
- [`bool: TryFrom<{integer}>`]
  (https://doc.rust-lang.org/stable/std/primitive.bool.html#impl-TryFrom%3Cu128%3E-for-bool)
- [`AtomicPtr::update`]
  (https://doc.rust-lang.org/stable/std/sync/atomic/struct.AtomicPtr.html#method.update)
- [`AtomicPtr::try_update`]
  (https://doc.rust-lang.org/stable/std/sync/atomic/struct.AtomicPtr.html#method.try_update)
- [`AtomicBool::update`]
  (https://doc.rust-lang.org/stable/std/sync/atomic/struct.AtomicBool.html#method.update)
- [`AtomicBool::try_update`]
  (https://doc.rust-lang.org/stable/std/sync/atomic/struct.AtomicBool.html#method.try_update)
- [`AtomicIn::update`]
  (https://doc.rust-lang.org/stable/std/sync/atomic/struct.AtomicIsize.html#method.update)
- [`AtomicIn::try_update`]
  (https://doc.rust-lang.org/stable/std/sync/atomic/struct.AtomicIsize.html#method.try_update)
- [`AtomicUn::update`]
  (https://doc.rust-lang.org/stable/std/sync/atomic/struct.AtomicUsize.html#method.update)
- [`AtomicUn::try_update`]
  (https://doc.rust-lang.org/stable/std/sync/atomic/struct.AtomicUsize.html#method.try_update)
- [`cfg_select!`]
  (https://doc.rust-lang.org/stable/std/macro.cfg_select.html)
- [`mod core::range`]
  (https://doc.rust-lang.org/stable/core/range/index.html)
- [`core::range::RangeInclusive`]
  (https://doc.rust-lang.org/stable/core/range/struct.RangeInclusive.html)
- [`core::range::RangeInclusiveIter`]
  (https://doc.rust-lang.org/stable/core/range/struct.RangeInclusiveIter.html)
- [`core::hint::cold_path`]
  (https://doc.rust-lang.org/stable/core/hint/fn.cold_path.html)
- [`<*const T>::as_ref_unchecked`]
  (https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.as_ref_unchecked)
- [`<*mut T>::as_ref_unchecked`]
  (https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.as_ref_unchecked-1)
- [`<*mut T>::as_mut_unchecked`]
  (https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.as_mut_unchecked)

These previously stable APIs are now stable in const contexts:

- [`fmt::from_fn`]
  (https://doc.rust-lang.org/stable/std/fmt/fn.from_fn.html)
- [`ControlFlow::is_break`]
  (https://doc.rust-lang.org/stable/core/ops/enum.ControlFlow.html#method.is_break)
- [`ControlFlow::is_continue`]
  (https://doc.rust-lang.org/stable/core/ops/enum.ControlFlow.html#method.is_continue)

Cargo
-----
- [docs(report): enhance man pages for `cargo report *`]
  (rust-lang/cargo#16430)

Rustdoc
-----
- [In search results, rank unstable items lower]
  (rust-lang/rust#149460)
- [Add new "hide deprecated items" setting in rustdoc]
  (rust-lang/rust#151091)

Compatibility Notes
-------------------
- [Array coercions may now result in less inference constraints than before]
  (rust-lang/rust#140283)
- Importing `$crate` without renaming, i.e. `use $crate::{self};`,
  is now no longer permitted due to stricter error checking for `self`
  imports.
- [const-eval: be more consistent in the behavior of padding during
  typed copies.] (rust-lang/rust#148967)
  In very rare cases, this may cause compilation errors due to
  bytes from parts of a pointer ending up in the padding bytes of
  a `const` or `static`.
- [A future-incompatibility warning lint `ambiguous_glob_imported_traits`
  is now reported when using an ambiguously glob imported trait]
  (rust-lang/rust#149058)
- [Check lifetime bounds of types mentioning only type parameters]
  (rust-lang/rust#149389)
- [Report more visibility-related ambiguous import errors]
  (rust-lang/rust#149596)
- [Deprecate `Eq::assert_receiver_is_total_eq` and emit future
  compatibility warnings on manual impls]
  (rust-lang/rust#149978)
- [powerpc64: Use the ELF ABI version set in target spec instead
  of guessing] (rust-lang/rust#150468)
  (fixes the ELF ABI used by the OpenBSD target)
- Matching on a `#[non_exhaustive]` enum [now reads the discriminant,
  even if the enum has only one variant]
  (rust-lang/rust#150681). This can cause
  closures to capture values that they previously wouldn't.
- `mut ref` and `mut ref mut` patterns, part of the unstable [Match
  Ergonomics 2024 RFC] (rust-lang/rust#123076),
  were accidentally allowed on stable within struct pattern field
  shorthand. These patterns are now correctly feature-gated as
  unstable in this position.
- [Add future-compatibility warning for derive helper attributes
  which conflict with built-in attributes]
  (rust-lang/rust#151152)
- [JSON target specs]
  (https://doc.rust-lang.org/rustc/targets/custom.html) have been
  destabilized and now require `-Z unstable-options` to use.
  Previously, they could not be used without the standard library,
  which has no stable build mechanism. In preparation for the
  `build-std` project adding that support, JSON target specs are
  being proactively gated to ensure they remain unstable even if
  `build-std` is stabilized. Cargo now includes the `-Z json-target-spec`
  CLI flag to automatically pass `-Z unstable-options` to the
  compiler when needed. See [#150151]
  (rust-lang/rust#150151), [#151534]
  (rust-lang/rust#150151), and
  [rust-lang/cargo#16557] (rust-lang/cargo#16557).
- [The arguments of `#[feature]` attributes on invalid targets are
  now checked] (rust-lang/rust#153764)

Internal Changes
----------------

These changes do not affect any public interfaces of Rust, but they
represent significant improvements to the performance or internals
of rustc and related tools.

- [Update to LLVM 22](rust-lang/rust#150722)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez left review comments

@notriddle notriddle notriddle approved these changes

Assignees

@notriddle notriddle

Labels

A-rustdoc-js Area: Rustdoc's JS front-end A-rustdoc-search Area: Rustdoc's search feature relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

5 participants

@lolbinarycat @rustbot @rust-log-analyzer @notriddle @GuillaumeGomez