Replace uses of MaybeUninit::uninit_array() with inline const blocks.#125082
Merged
bors merged 1 commit intorust-lang:masterfrom Jun 24, 2024
Merged
Replace uses of MaybeUninit::uninit_array() with inline const blocks.#125082bors merged 1 commit intorust-lang:masterfrom
MaybeUninit::uninit_array() with inline const blocks.#125082bors merged 1 commit intorust-lang:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[This PR originally contained the changes in #125995 too. See edit history for the original PR description.]
The documentation of
MaybeUninit::uninit_array()says:The PR adding it also said: #65580 (comment)
That time has come to pass — inline const expressions are stable — so
MaybeUninit::uninit_array()is now unnecessary. The only remaining question is whether it is an important enough convenience to keep it around.I believe it is net good to remove this function, on the principle that it is better to compose two orthogonal features (
MaybeUninitand array construction) than to have a specific function for the specific combination, now that that is possible.