Skip to content

Fixed match same arms vertical tab#16844

Open
shashu8660 wants to merge 3 commits intorust-lang:masterfrom
shashu8660:fix-match-same-arms-vertical-tab2
Open

Fixed match same arms vertical tab#16844
shashu8660 wants to merge 3 commits intorust-lang:masterfrom
shashu8660:fix-match-same-arms-vertical-tab2

Conversation

@shashu8660
Copy link
Copy Markdown

@shashu8660 shashu8660 commented Apr 11, 2026

changelog:[match_same_arms.rs] : considering all the rust whitespace including vertical tab .

This change ensures that span extension considers all Rust whitespace,including vertical tab (\x0B), instead of only ASCII whitespace.

Previously, spans could stop early when non-ASCII whitespace was present,leading to incorrect highlighting in diagnostics.

from the issue :rustfoundation/interop-initiative#53
i have worked on [short span in same match arms]:(https://github.com/rust-lang/rust/blob/e0e95a71872dfe9e15d22bddea9ac45c85ddda1a/src/tools/clippy/clippy_lints/src/matches/match_same_arms.rs#L180)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 11, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 11, 2026

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: 7 candidates
  • 7 candidates expanded to 7 candidates
  • Random selection from Jarcho, dswij, llogiq, samueltardieu

@shashu8660
Copy link
Copy Markdown
Author

@github-actions
Copy link
Copy Markdown

Lintcheck changes for b208bb5

Lint Added Removed Changed
clippy::match_same_arms 0 0 286

This comment will be updated if you push new changes

@oli-obk
Copy link
Copy Markdown
Contributor

oli-obk commented Apr 14, 2026

Hi,

You have repeatedly used LLMs to generate your outreachy work, even though it was explicitly stated that they are only tone used as learning tools. Directly generating the answers (even with a human in the loop) is against the spirit of how we run our outreachy program.

We are a community of contributors, not just a code repository. Thus we focus on contributors who desire to learn to produce high quality contributions.

We are thus banning you as per our policies (1) and contribution standards (2). You can contact the moderation team to discuss and possibly reconsider your ban.

Thanks for understanding

Oli in the name of the mod team and the outreachy mentors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants