doc_markdown: split words on { and }#16838
Closed
barry3406 wants to merge 1 commit intorust-lang:masterfrom
Closed
doc_markdown: split words on { and }#16838barry3406 wants to merge 1 commit intorust-lang:masterfrom
{ and }#16838barry3406 wants to merge 1 commit intorust-lang:masterfrom
Conversation
Adjacent brace-delimited items separated by `.` (e.g.
`{SymbolA}.{symbol_b}`) were tokenized as a single word, so the
suggestion ended up wrapping both items in one pair of backticks
(``{`SymbolA}.{symbol_b`}``).
Treat `{` and `}` as word boundaries alongside whitespace and `'`,
so each braced item is processed independently.
Collaborator
|
Some changes occurred in clippy_lints/src/doc cc @notriddle |
rustbot
added
the
S-waiting-on-review
Collaborator
|
rustbot has assigned @samueltardieu. Use Why was this reviewer chosen?The reviewer was selected based on:
|
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16819
When two brace-delimited items are separated by
.(e.g.{SymbolA}.{symbol_b}), the word splitter only broke on whitespace and', so the whole sequence was tokenized as a single word. After trimming non-alphanumeric chars from the ends, that leftSymbolA}.{symbol_b, whichhas_underscorethen matched and the lint wrapped the entire span in one pair of backticks.Treating
{and}as word boundaries makes each braced item get processed independently — same as if there had been whitespace between them.Before
After
The case with whitespace between the braces (
{SymbolA} and {symbol_b}) was already being handled correctly and continues to work — the regression test covers both shapes.changelog: [
doc_markdown]: correctly handle adjacent brace-delimited items separated by.