Skip to content

Fix: lint groups priority comma #16813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shivangisharma4 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: lint groups priority comma #16813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clippy_lints/src/cargo/lint_groups_priority.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ fn check_table(cx: &LateContext<'_>, table: &DeTable<'_>, known_groups: &FxHashS
diag.span_suggestion_verbose(
config_span,
format!(
"to have lints override the group set `{}` to a lower priority",
"to have lints override the group, set `{}` to a lower priority",
group.as_ref()
),
format!("{{ level = {:?}, priority = {low_priority} }}", group_config.level),
Expand Down
14 changes: 7 additions & 7 deletions tests/ui-cargo/lint_groups_priority/fail/Cargo.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ error: lint group `rust_2018_idioms` has the same priority (0) as a lint
|
= note: the order of the lints in the table is ignored by Cargo
= note: `#[deny(clippy::lint_groups_priority)]` on by default
help: to have lints override the group set `rust_2018_idioms` to a lower priority
help: to have lints override the group, set `rust_2018_idioms` to a lower priority
|
7 - rust_2018_idioms = "warn"
7 + rust_2018_idioms = { level = "warn", priority = -1 }
Expand All @@ -20,12 +20,12 @@ error: lint group `unused` has the same priority (0) as a lint
|
10 | unused = { level = "deny" }
| ^^^^^^ ------------------ has an implicit priority of 0
11 | unused_braces = { level = "allow", priority = 1 }
11 | unused_braces = { level = "allow", p...
12 | unused_attributes = { level = "allow" }
| ----------------- has the same priority as this lint
|
= note: the order of the lints in the table is ignored by Cargo
help: to have lints override the group set `unused` to a lower priority
help: to have lints override the group, set `unused` to a lower priority
|
10 | unused = { level = "deny", priority = -1 }
| +++++++++++++++
Expand All @@ -35,11 +35,11 @@ error: lint group `pedantic` has the same priority (-1) as a lint
|
15 | pedantic = { level = "warn", priority = -1 }
| ^^^^^^^^
16 | similar_names = { level = "allow", priority = -1 }
16 | similar_names = { level = "allow", priority =...
| ------------- has the same priority as this lint
|
= note: the order of the lints in the table is ignored by Cargo
help: to have lints override the group set `pedantic` to a lower priority
help: to have lints override the group, set `pedantic` to a lower priority
|
15 - pedantic = { level = "warn", priority = -1 }
15 + pedantic = { level = "warn", priority = -2 }
Expand All @@ -54,7 +54,7 @@ error: lint group `rust_2018_idioms` has the same priority (0) as a lint
| ------------------ has the same priority as this lint
|
= note: the order of the lints in the table is ignored by Cargo
help: to have lints override the group set `rust_2018_idioms` to a lower priority
help: to have lints override the group, set `rust_2018_idioms` to a lower priority
|
19 - rust_2018_idioms = "warn"
19 + rust_2018_idioms = { level = "warn", priority = -1 }
Expand All @@ -69,7 +69,7 @@ error: lint group `pedantic` has the same priority (0) as a lint
| ------------- has the same priority as this lint
|
= note: the order of the lints in the table is ignored by Cargo
help: to have lints override the group set `pedantic` to a lower priority
help: to have lints override the group, set `pedantic` to a lower priority
|
23 - pedantic = "warn"
23 + pedantic = { level = "warn", priority = -1 }
Expand Down
Loading