Open
Conversation
- replace `.map_or_else()` with if-let-else -- the inline closure was just a bit too complex to be readable - improve the documentation a bit
- In the first suggestion example, use `snippet_with_applicability` to correctly adjust applicability. We don't want to be giving wrong advice right away. - Explain when to use `snippet` vs `snippet_with_applicability` - Recommend using `"_"` as the fallback string most of the time; adjust the examples throughout accordingly.
rustbot
added
the
S-waiting-on-review
Collaborator
|
r? @flip1995 rustbot has assigned @flip1995. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog: none
cc @Jarcho: I do realize you're currently reworking snippets (apparently to a great extent), but I think it'd still be worthwhile to document the current process, because in my experience this is a common struggle point among new contributors. Feel free to just revert these changes in your PR(s), if necessary.