New lint: bitwise_not_zero, rewrite !0 as {int}::MAX#16806
Open
nik-rev wants to merge 1 commit intorust-lang:masterfrom
Open
New lint: bitwise_not_zero, rewrite !0 as {int}::MAX#16806nik-rev wants to merge 1 commit intorust-lang:masterfrom
bitwise_not_zero, rewrite !0 as {int}::MAX#16806nik-rev wants to merge 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
needs-fcp
Collaborator
|
rustbot has assigned @samueltardieu. Use Why was this reviewer chosen?The reviewer was selected based on:
|
nik-rev
force-pushed
the
bitwise-not-on-zero
branch
2 times, most recently
from
df6f69d to
beb9d9a
Compare
|
Lintcheck changes for 1acfd24
This comment will be updated if you push new changes |
nik-rev
force-pushed
the
bitwise-not-on-zero
branch
2 times, most recently
from
95ec375 to
299fac0
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
nik-rev
force-pushed
the
bitwise-not-on-zero
branch
2 times, most recently
from
5c65746 to
5620a80
Compare
This comment has been minimized.
This comment has been minimized.
nik-rev
force-pushed
the
bitwise-not-on-zero
branch
2 times, most recently
from
ec2a486 to
6769831
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
samueltardieu
requested changes
Apr 5, 2026
| "usage of the bitwise not `!` on zero", | ||
| "this is clearer written as the maximum value", | ||
| format!("{integer}::MAX"), | ||
| Applicability::MaybeIncorrect, |
Author
There was a problem hiding this comment.
It suggests to rewrite with u32::MAX, but someone may not have that in scope. e.g. they might define struct u32;
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
Collaborator
|
This lint has been nominated for inclusion. |
ada4a
requested changes
Apr 5, 2026
nik-rev
force-pushed
the
bitwise-not-on-zero
branch
3 times, most recently
from
4a63587 to
469ad15
Compare
nik-rev
changed the title
bitwise_not_zero, rewrite !0 as i32::MAXbitwise_not_zero, rewrite !0 as {int}::MAX
nik-rev
force-pushed
the
bitwise-not-on-zero
branch
2 times, most recently
from
f9dd43d to
91d9717
Compare
nik-rev
force-pushed
the
bitwise-not-on-zero
branch
4 times, most recently
from
b8c7588 to
441cc5d
Compare
Co-authored-by: Samuel Tardieu <sam@rfc1149.net> Co-authored-by: Ada Alakbarova <58857108+ada4a@users.noreply.github.com>
nik-rev
force-pushed
the
bitwise-not-on-zero
branch
from
441cc5d to
1acfd24
Compare
Author
|
@rustbot ready |
rustbot
removed
the
S-waiting-on-author
rustbot
added
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lint suggests to rewrite expressions like:
As:
Because
!0is confusing, it performs the bitwise NOT operator, equivalent to specifying theMAXvalue.changelog: [
bitwise_new_lint]: added lint that replaces!0with{int}::MAX