feat: detect == 0 on unsigned types as a manual_clamp lower bound#16800
Open
LesnyRumcajs wants to merge 1 commit intorust-lang:masterfrom
Open
feat: detect == 0 on unsigned types as a manual_clamp lower bound#16800LesnyRumcajs wants to merge 1 commit intorust-lang:masterfrom
== 0 on unsigned types as a manual_clamp lower bound#16800LesnyRumcajs wants to merge 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
the
S-waiting-on-review
Collaborator
|
r? @dswij rustbot has assigned @dswij. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16792
For unsigned types,
if x == 0can be expressed asif x < 1. The former was not caught bymanual_clamplint; this PR normalizes it so that cases as described in the linked issue are caught.changelog:
manual_clampdetect== 0on unsigned types as a clamp lower bound