disable f16 tests for the cranelift backend#520
disable f16 tests for the cranelift backend#520folkertdev wants to merge 1 commit intorust-lang:masterfrom
f16 tests for the cranelift backend#520Conversation
|
So actually it looks like the failure is in The libc implementation seems doable to implement, actually? |
There are still a bunch of cases where the LLVM backend also says it doesn't support f16 math. So either way |
|
I believe that is because we still support older LLVM versions? With LLVM 22 (Arch::X86_64, Os::Windows) if *target_env == Env::Gnu && *target_abi != CfgAbi::Llvm => { |
|
To unblock the cg_clif rustc update, I have for now added a patch that remove all f16 support in portable-simd again. |
| // FIXME: the cranelift backend runs these tests for x86_64-pc-windows-gnu | ||
| // where it does not have full support for f16 yet. | ||
| #[cfg(target_has_reliable_f16_math)] |
There was a problem hiding this comment.
I'd drop this comment, it's not a cranelift-specific issue and the target_has_reliable_f16_math is effectively already a fixme.
|
At this time I'd still consider it more or less a requirement to gate anything that may codegen behind |
relevant for the cranelift backend, possibly other cases/targets too
1f19d30 to
f40da91
Compare
fixes #519
@bjorn3 does this look like it would work?