Skip to content

sync to nightly-2026-04-11 #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
folkertdev wants to merge 3 commits into
base: master
Choose a base branch
from
Open

sync to nightly-2026-04-11 #516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cfe8ac6
simd_fmin/fmax: make semantics and name consistent with scalar intrin…
RalfJung Mar 18, 2026
0ff6ec9
bump toolchain to `nightly-2026-04-11`
folkertdev Apr 11, 2026
a4e345c
use larger ulps for `log` because it uses 2 inexact operations
folkertdev Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/core_simd/src/simd/num/float.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,13 +385,13 @@ macro_rules! impl_trait {
#[inline]
fn simd_min(self, other: Self) -> Self {
// Safety: `self` and `other` are float vectors
unsafe { core::intrinsics::simd::simd_fmin(self, other) }
unsafe { core::intrinsics::simd::simd_minimum_number_nsz(self, other) }
}

#[inline]
fn simd_max(self, other: Self) -> Self {
// Safety: `self` and `other` are floating point vectors
unsafe { core::intrinsics::simd::simd_fmax(self, other) }
unsafe { core::intrinsics::simd::simd_maximum_number_nsz(self, other) }
}

#[inline]
Expand Down
31 changes: 13 additions & 18 deletions crates/std_float/tests/float.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,23 +33,6 @@ macro_rules! unary_approx_test {
}
}

macro_rules! binary_approx_test {
{ $scalar:tt, $($func:tt),+ } => {
test_helpers::test_lanes! {
$(
fn $func<const LANES: usize>() {
test_helpers::test_binary_elementwise_approx(
&core_simd::simd::Simd::<$scalar, LANES>::$func,
&$scalar::$func,
&|_, _| true,
16,
)
}
)*
}
}
}

macro_rules! ternary_test {
{ $scalar:tt, $($func:tt),+ } => {
test_helpers::test_lanes! {
Expand All @@ -76,7 +59,19 @@ macro_rules! impl_tests {

// https://github.com/rust-lang/miri/issues/3555
unary_approx_test! { $scalar, sin, cos, exp, exp2, ln, log2, log10 }
binary_approx_test! { $scalar, log }

// The implementation of log is a.ln() / b.ln(), so there are 2 inexact operations,
// hence a larger ulps is needed.
test_helpers::test_lanes! {
fn log<const LANES: usize>() {
test_helpers::test_binary_elementwise_approx(
&core_simd::simd::Simd::<$scalar, LANES>::log,
&$scalar::log,
&|_, _| true,
32,
)
}
}

test_helpers::test_lanes! {
fn fract<const LANES: usize>() {
Expand Down
2 changes: 1 addition & 1 deletion rust-toolchain.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
[toolchain]
channel = "nightly-2026-03-18"
channel = "nightly-2026-04-11"
components = ["rustfmt", "clippy", "miri", "rust-src"]
Loading