Add f16 vector support#513
Conversation
223b255 to
a8ff036
Compare
This comment has been minimized.
This comment has been minimized.
fc96ee5 to
fd68e12
Compare
|
The latest release of |
|
I'm not sure what's up with the wasm tests, locally running |
|
Might be worth trying a |
|
Turns out this LLVM IR with define <8 x i16> @foo(<8 x half> %x) {
start:
%1 = fcmp uno <8 x half> %x, zeroinitializer
%2 = sext <8 x i1> %1 to <8 x i16>
ret <8 x i16> %2
}I'll debug that further, of course. Should we block on this? |
|
Historically we've identified the function that generates the bad LLVM behavior and replace it with a temporary scalar loop for that architecture. The next best option is if you could find the test that hits it, disable it for that architecture. I don't think we need to block on this, but probably report it to LLVM. |
|
I believe it's any comparison on |
llvm hangs in that case, see llvm/llvm-project#189251
|
@calebzulawski if that's acceptable, this should be ready now. I did open an LLVM issue also llvm/llvm-project#189251. |
|
@calebzulawski quick ping, or should I assign someone else? |
|
Sorry about that, thanks! |
closes #484
This is blocked on a
proptestrelease: the required changes have been merged, but not released yet.