Skip to content

fix: prevent '?' shortcut from intercepting input in code editors #3065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kartik-py12 wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −1
Open

fix: prevent '?' shortcut from intercepting input in code editors #3065

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion crates/mdbook-html/front-end/js/book.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -706,11 +706,21 @@ aria-label="Show hidden lines"></button>';

// Usually needs the Shift key to be pressed
switch (e.key) {
case '?':
case '?': {
const active = document.activeElement;
if (active &&
(
active.tagName === 'INPUT' ||
active.tagName === 'TEXTAREA' ||
active.isContentEditable
)) {
return;
}
e.preventDefault();
showHelp();
break;
}
}

// Rest of the keys are only active when the Shift key is not pressed
if (e.shiftKey) {
Expand Down