feat: URLs with no index.html suffix #3047
Open
jhult wants to merge 12 commits intorust-lang:masterfrom
Open
Conversation
|
Certainly fixes my issue #3028 . Would love to get this in. |
Contributor
Author
|
@ehuss or @Dylan-DPC, I think many people would appreciate this being merged. I'd love any feedback you have to share. |
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
When clean URLs are enabled, pages are output to subdirectories (e.g., `foo/bar/index.html`). In-content relative links like `[Link](other.md)` were being converted to `other/` without accounting for the current page's subdirectory location. The fix modifies `fix_link` to: 1. Take the source chapter path as a parameter 2. Calculate `path_to_root` using `clean_url_path_to_root` 3. Prepend `path_to_root` to the fixed link This ensures in-content links work correctly from any page depth.
- add tests for ResourceHelper clean URL paths
The preprocessor now handles {{#if}}...{{else}}...{{/if}} blocks by keeping only the first branch and stripping trailing whitespace. Also adds required meta object for ESLint 10 compatibility.
|
Just had to hop into the discussion and say that this fixed my issue with cloudflare pages Before: https://ad2d70e6.csbook-a6u.pages.dev/ Thanks for your work <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1251
Vaguely related PRs: #2570, #2993, #3028, #3034, #3038