test: Fix printing bitwise float reprs in error printing#1205
Merged
tgross35 merged 1 commit intorust-lang:mainfrom Apr 19, 2026
Merged
test: Fix printing bitwise float reprs in error printing#1205tgross35 merged 1 commit intorust-lang:mainfrom
tgross35 merged 1 commit intorust-lang:mainfrom
Conversation
In commit "test: Consolidate `Hexf`, `Hexi`, and the `Hex` trait" we unintentionally lost the difference between float hex and bitwise hex formatting; instead, the float hex was getting printed twice. Resolve this by printing the integer hex whenever the `-` format modifier is specified. This also makes things simpler because we no longer need to keep track of whether an `impl DisplayHex` is a float with `.to_bits()` available or an integer without it, we can always just try to print both forms. As a result, we can use a common error message for all validation checks.
tgross35
force-pushed
the
fix-test-print
branch
from
6709cc6 to
9a0a195
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In commit "test: Consolidate
Hexf,Hexi, and theHextrait" we unintentionally lost the difference between float hex and bitwise hex formatting; instead, the float hex was getting printed twice. Resolve this by printing the integer hex whenever the-format modifier is specified. This also makes things simpler because we no longer need to keep track of whether animpl DisplayHexis a float with.to_bits()available or an integer without it, we can always just try to print both forms.As a result, we can use a common error message for all validation checks.