Skip to content

Copy cargo clean target-dir validation tests to clean_new_layout.rs#16878

Merged
epage merged 1 commit intorust-lang:masterfrom
ranger-ross:copy-tests
Apr 13, 2026
Merged

Copy cargo clean target-dir validation tests to clean_new_layout.rs#16878
epage merged 1 commit intorust-lang:masterfrom
ranger-ross:copy-tests

Conversation

@ranger-ross
Copy link
Copy Markdown
Member

What does this PR try to resolve?

#16712 added some additional tests to clean.rs but did not add them to clean_new_layout.rs (which mirrors clean.rs with -Zbuild-dir-new-layout enabled)

While these tests do not depend on the new build-dir layout, #16807 renames clean.rs to clean_legacy_layout.rs and clean_new_layout.rs to clean.rs.
Having the tests be in both makes the switch easier and results in less diffs.

I pulled this out into its own PR as the stabilization has grown pretty large.

How to test and review this PR?

cargo test clean

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 13, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 13, 2026

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ehuss, @epage, @weihanglo
  • @ehuss, @epage, @weihanglo expanded to ehuss, epage, weihanglo
  • Random selection from ehuss, epage, weihanglo

@epage epage enabled auto-merge April 13, 2026 15:42
@epage epage added this pull request to the merge queue Apr 13, 2026
Merged via the queue into rust-lang:master with commit 80abaf4 Apr 13, 2026
29 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants