Copy cargo clean target-dir validation tests to clean_new_layout.rs#16878
Merged
epage merged 1 commit intorust-lang:masterfrom Apr 13, 2026
Merged
Copy cargo clean target-dir validation tests to clean_new_layout.rs#16878epage merged 1 commit intorust-lang:masterfrom
epage merged 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
r? @ehuss rustbot has assigned @ehuss. Use Why was this reviewer chosen?The reviewer was selected based on:
|
epage
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
#16712 added some additional tests to
clean.rsbut did not add them toclean_new_layout.rs(which mirrorsclean.rswith-Zbuild-dir-new-layoutenabled)While these tests do not depend on the new build-dir layout, #16807 renames
clean.rstoclean_legacy_layout.rsandclean_new_layout.rstoclean.rs.Having the tests be in both makes the switch easier and results in less diffs.
I pulled this out into its own PR as the stabilization has grown pretty large.
How to test and review this PR?
cargo test clean