avm2: Remove pushshort op#23491
Merged
Lord-McSweeney merged 2 commits intoruffle-rs:masterfrom Apr 19, 2026
Merged
Conversation
After ruffle-rs#21925, there's no reason for the two to be different ops
Lord-McSweeney
added
A-avm2
SuchAFuriousDeath
approved these changes
Apr 19, 2026
kjarosh
approved these changes
Apr 19, 2026
These apply to all values that can be represented as an `i32` and a `u32`
Lord-McSweeney
force-pushed
the
avm2-no-pushshort
branch
from
8705403 to
c466fe4
Compare
Lord-McSweeney
removed
the
waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is possible after #21925 and unblocks some additional (future) peephole optimizations for us.
Also make
contains_valid_integerandcontains_valid_unsignedtrack those states more accurately.