avm1: Add Value::from_usize_lossy and Value::from_u64_lossy#23476
Open
kjarosh wants to merge 1 commit intoruffle-rs:masterfrom
Open
avm1: Add Value::from_usize_lossy and Value::from_u64_lossy#23476kjarosh wants to merge 1 commit intoruffle-rs:masterfrom
kjarosh wants to merge 1 commit intoruffle-rs:masterfrom
Conversation
kjarosh
added
A-avm1
Similarly to AVM2, the From impl for Value was not compliant with the expectations: the conversions were not always lossless. This patch removes the impls and instead moves the conversions to Value::from_usize_lossy and Value::from_u64_lossy, which make it clear that the conversion is lossy.
kjarosh
force-pushed
the
avm1-value-lossy
branch
from
099563b to
67202bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similarly to AVM2, the From impl for Value was not compliant with the expectations: the conversions were not always lossless.
This patch removes the impls and instead moves the conversions to Value::from_usize_lossy and Value::from_u64_lossy, which make it clear that the conversion is lossy.