avm2: Improve DisplayObject.rotationZ stubs#23469
Open
kjarosh wants to merge 1 commit intoruffle-rs:masterfrom
Open
avm2: Improve DisplayObject.rotationZ stubs#23469kjarosh wants to merge 1 commit intoruffle-rs:masterfrom
kjarosh wants to merge 1 commit intoruffle-rs:masterfrom
Conversation
Z axis is placed perpendicular to the x/y plane, and effectively is the same as regular rotation. The API as described in docs works also the same way. By delegating DisplayObject.rotationZ to DisplayObject.rotation, we can make the content work that used rotationZ the same way as rotation. This does not address potential interactions with Matrix3D, etc., and thus the method is still marked as a stub.
kjarosh
added
A-avm2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Z axis is placed perpendicular to the x/y plane, and effectively is the same as regular rotation. The API as described in docs works also the same way.
By delegating DisplayObject.rotationZ to DisplayObject.rotation, we can make the content work that used rotationZ the same way as rotation.
This does not address potential interactions with Matrix3D, etc., and thus the method is still marked as a stub.