core: In MovieClip's avm1_mouse_pick, don't check for AVM2 content#23462
Draft
ChrisCPI wants to merge 1 commit intoruffle-rs:masterfrom
Draft
core: In MovieClip's avm1_mouse_pick, don't check for AVM2 content#23462ChrisCPI wants to merge 1 commit intoruffle-rs:masterfrom
avm1_mouse_pick, don't check for AVM2 content#23462ChrisCPI wants to merge 1 commit intoruffle-rs:masterfrom
Conversation
danielhjacobs
added
waiting-on-review
kjarosh
removed
the
waiting-on-review
Contributor
Author
|
Turns out this isn't entirely correct; SWF 9 allows for moving AVM1 content outside of the parenting Loader. Will revert the changes to |
This is theoretically not possible, because AVM2 movies loaded into AVM1 are always interpreted as AVM1 (ruffle-rs#23183), and `mouse_pick_avm1` is never run in AVM2.
ChrisCPI
force-pushed
the
mc-mouse-pick-cleanup
branch
from
d02251f to
e25c9dc
Compare
ChrisCPI
changed the title
MovieClip mouse picks, don't check for if a child is the other AVMavm1_mouse_pick, don't check for AVM2 content
Member
|
Can you add a test for that case? |
Contributor
Author
|
Moving the avm1 movie outside the loader is already covered in the |
Member
|
We should add a test for mouse picking specifically. The previous version of the PR should fail tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is theoretically not possible, because AVM2 movies loaded into AVM1 are always interpreted as AVM1 (#23183), and
mouse_pick_avm1is never run in AVM2.