Use saturating_sub when calculating swf header size to prevent panic#23324
Open
SuchAFuriousDeath wants to merge 2 commits intoruffle-rs:masterfrom
Open
Use saturating_sub when calculating swf header size to prevent panic#23324SuchAFuriousDeath wants to merge 2 commits intoruffle-rs:masterfrom
saturating_sub when calculating swf header size to prevent panic#23324SuchAFuriousDeath wants to merge 2 commits intoruffle-rs:masterfrom
Conversation
Lord-McSweeney
added
T-fix
kjarosh
reviewed
Mar 24, 2026
SuchAFuriousDeath
force-pushed
the
loaded_bytes_overflow
branch
from
bdb6a73 to
0d72fd7
Compare
SuchAFuriousDeath
force-pushed
the
loaded_bytes_overflow
branch
from
0d72fd7 to
a2da810
Compare
SuchAFuriousDeath
force-pushed
the
loaded_bytes_overflow
branch
from
a2da810 to
d21038e
Compare
Member
|
Just for the record, we talked about this on Discord: we need two tests, one where the reported size is bigger than the real size, and one where it's smaller. |
kjarosh
added
waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23323