web: Open new tabs beside the current one by extension#23313
Draft
pzhlkj6612 wants to merge 1 commit intoruffle-rs:masterfrom
Draft
web: Open new tabs beside the current one by extension#23313pzhlkj6612 wants to merge 1 commit intoruffle-rs:masterfrom
pzhlkj6612 wants to merge 1 commit intoruffle-rs:masterfrom
Conversation
* Changes:
* Open new tabs beside the current tab instead of at default position (after all tabs).
* Remove redundant "promisify" wrapper from "tabs.create" calls.
* Test Environment:
* Windows 11, Firefox 143.0.
* Windows 11, Chrome 146.0.7680.80.
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: pzhlkj6612 <29089388+pzhlkj6612@users.noreply.github.com>
danielhjacobs
added
A-web
evilpie
requested changes
Apr 11, 2026
Collaborator
evilpie
left a comment
evilpie
left a comment
There was a problem hiding this comment.
Instead of setting the index, you should set the openerTabId to the right tab. In Firefox at least this will automatically open the new tab after the current tab. This behaviour is actually controllable by the user using the about:config preference browser.tabs.insertRelatedAfterCurrent.
Author
Thank you, I didn't know that parameter. Let me check a better appraoch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! Thanks for maintaining Ruffle. I can't always go back to my childhood to play old games without your hard work.
The logic about opening new tabs in the browser extension can be improved. I have so many tabs open. New ones opened by Ruffle always go to the end of the looooong tab list. I asked AI and have modified the code to let new tabs open beside the current one.
I'm not able to test the "onboard.html" page because I can't find a way to trigger the "INSTALL" event with unpacked extension. In Firefox Nightly, installing XPI file with setting
xpinstall.signatures.requiredtofalsedoes not work. I can't figure it out.The two changes about "player.html" have been tested, though.
Here is the commit message:
Please review, thank you!