Move both controller and request specs on controller move#175
Open
Envek wants to merge 1 commit intorubyatscale:mainfrom
Open
Move both controller and request specs on controller move#175Envek wants to merge 1 commit intorubyatscale:mainfrom
Envek wants to merge 1 commit intorubyatscale:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #174
In
Packs::Private::FileMoveOperationI've changed methodspec_file_move_operationtospec_file_move_operations(returning array) because controllers can have both regular controller specs and request specs and we probably want to move both! (And I have both in a real app I have at hand)Also that should be more future proof even though the method itself is way too specific (maybe this is the time to implement some strategy pattern mentioned in code comments above? 🤔)