Add the ability to use the Prism parser#66
Merged
k-tsj merged 1 commit intoruby:masterfrom Apr 22, 2026
Merged
Conversation
Previously, this relied on Ripper exclusively. This commit adds the ability to use the Prism parser instead. This enables power_assert to handle slightly more syntax, and to not get confused on lines that are lacking column information and have multiple of the same token. It is also faster, when examining runs times of the ident extraction methods. I have left Ripper as the default parser, as that would require more of a discussion going forward. But switching would yield the above benefits, as well as allowing this to run on other Rubies besides just CRuby.
Member
|
Sorry for the late response. BTW, power_assert doesn't really promote it, but it does have a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, this relied on Ripper exclusively. This commit adds the ability to use the Prism parser instead. This enables power_assert to handle slightly more syntax, and to not get confused on lines that are lacking column information and have multiple of the same token. It is also faster, when examining runs times of the ident extraction methods.
I have left Ripper as the default parser, as that would require more of a discussion going forward. But switching would yield the above benefits, as well as allowing this to run on other Rubies besides just CRuby.
cc @Earlopain