added deps to app resource file#2
Open
bunnylushington wants to merge 1 commit intorpip:masterfrom
Open
Conversation
Owner
|
Thanks, @kevinmontuori! It's generally recommended to use the I'll add them right away. |
Owner
|
Added the dependencies to the Please try again and let me know if that solves the problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi -- I ran into a small issue while building up a release where the fakerl deps were not declared in its app file. (I use fakerl to generate data for automated post-release testing, which is why it's part of the release ... I can imagine wondering.) Anyhow, here's a quick PR with the update. Note that this change is not compatible if projects bundling fakerl declared fakerl's deps in their own app file (relx, at least, complains that duplication applications are included).
Anyhow, thanks again for the library, it's been a godsend!