Correcting crash when disallowed character appears in post title. #9
Open
AtticusBeachy wants to merge 2 commits intorocurley:masterfrom
Open
Correcting crash when disallowed character appears in post title. #9AtticusBeachy wants to merge 2 commits intorocurley:masterfrom
AtticusBeachy wants to merge 2 commits intorocurley:masterfrom
Conversation
Certain characters cannot be included in a file name in Windows. This change strips out all characters from the title except numbers, letters, and spaces.
Prevent crashes from disallowed characters in the tile on a blacklist basis instead of a whitelist basis.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This time I managed to fix the bug without creating new ones (I hope). I tested it on the failure case you pointed out for the previous pull request (https://glowfic.com/posts/5404) and it worked.