Turn require Coq depr warnings as error by default#21851
Turn require Coq depr warnings as error by default#21851proux01 wants to merge 2 commits intorocq-prover:masterfrom
Conversation
8e19fdd to
d54ba77
Compare
0c97b2e to
5bae0b3
Compare
5bae0b3 to
84c97af
Compare
* Adapt to rocq-prover/rocq#21851 * Update CI 9.2.0 was released last week but we don't have the docker image yet.
|
What is the reason for this? (Is there any urgency?) Given the somewhat fluid boundary between corelib and stdlib, it seems much nicer to have a common prefix that can be used to refer to both of them. I was under the impression that the stdlib split was done somewhat tentatively, with the option to revert it if it seemed to do more harm than good. Has there been a debrief of the impacts of doing the split and which impacts are positive and which are negative? |
|
These deprecations date back from 9.0, planing actual removal in 9.4 is already way offer the official 2 successive versions compatibility policy. Note that you still have your common require prefix, it's just |
84c97af to
bf2dfa7
Compare
|
Dropping compatibility after two versions is fine for changes that are unambiguously positive, but you have not addressed my other question:
|
|
That's pretty orthogonal. The Even if you disagree, this is not yet removing the deprecation so you have one more release cycle to trigger any discussion you want to have. |
|
This seems like another case where the as-error step is useless. IMO we can leave this as a normal warning for a while longer. |
|
I disagree on this one. As a user I'd prefer to have an error by default warning (that I can easily silence) and later don't even notice the change because I'd probably have adapted by then than forgeting about the warning and later getting a more surprising error that I have no choice but to adapt "immediatly". |
Overlays (to be merged before the current PR)