Skip to content

fix: add hints for Num.to_str and Inspect.to_str errors #9283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sim-hu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add hints for Num.to_str and Inspect.to_str errors #9283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/canonicalize/ModuleEnv.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -825,6 +825,24 @@ pub fn diagnosticToReport(self: *Self, diagnostic: CIR.Diagnostic, allocator: st
self.getLineStartsAll(),
);

if (std.mem.eql(u8, ident_name, "Num.to_str")) {
try report.document.addLineBreak();
try report.document.addLineBreak();
try report.document.addAnnotated("Hint:", .emphasized);
try report.document.addReflowingText(" Instead of ");
try report.document.addInlineCode("Num.to_str(value)");
try report.document.addReflowingText(", use method syntax: ");
try report.document.addInlineCode("value.to_str()");
} else if (std.mem.eql(u8, ident_name, "Inspect.to_str")) {
try report.document.addLineBreak();
try report.document.addLineBreak();
try report.document.addAnnotated("Hint:", .emphasized);
try report.document.addInlineCode(" Inspect.to_str");
try report.document.addReflowingText(" has been renamed to ");
try report.document.addInlineCode("Str.inspect");
try report.document.addReflowingText(".");
}

break :blk report;
},
.exposed_but_not_implemented => |data| blk: {
Expand Down
Loading