Skip to content

Replace CIR interpreter with LIR interpreter #9272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lukewilliamboswell wants to merge 138 commits into
base: main
Choose a base branch
from
Draft

Replace CIR interpreter with LIR interpreter #9272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
138 commits
Select commit Hold shift + click to select a range
d401885
Replace CIR interpreter with CIR → LIR interpreter pipeline
lukewilliamboswell Mar 22, 2026
cabc97c
Fix cell symbol identity mismatch for partial record spread in MIR→LIR
lukewilliamboswell Mar 23, 2026
35d08ae
Fix monomorphize panic on annotation-only local function calls
lukewilliamboswell Mar 23, 2026
888559a
Fix recursive tag union layout resolution in MIR monotype resolver
lukewilliamboswell Mar 23, 2026
aff5486
Increase LIR interpreter max_call_depth to 1024 and re-enable recursi…
lukewilliamboswell Mar 23, 2026
4785478
remove old plan files that should never have been merged into main
lukewilliamboswell Mar 23, 2026
80456b7
Fix str_from_utf8 layout mismatch in LIR interpreter
lukewilliamboswell Mar 23, 2026
445c7e3
Fix closure monomorphization and MIR Lower capture panics
lukewilliamboswell Mar 23, 2026
738e6e3
Add parallel eval test runner with job queue and crash protection
lukewilliamboswell Mar 22, 2026
dde35b8
Run all backends (interpreter, dev, wasm, llvm) in eval test runner a…
lukewilliamboswell Mar 22, 2026
6701f96
Make `zig build test-eval` run the parallel runner instead of old eva…
lukewilliamboswell Mar 22, 2026
466850d
Add eval test migration guide for porting tests to parallel runner
lukewilliamboswell Mar 22, 2026
58d8232
Add --coverage flag to eval test runner, separate coverage-eval build…
lukewilliamboswell Mar 23, 2026
1c59389
Skip performance summary in coverage mode
lukewilliamboswell Mar 23, 2026
e9b62b3
Fix coverage-eval to run independently of parser coverage
lukewilliamboswell Mar 23, 2026
d16ae14
Add --help, backend skip support, and per-phase timing to eval test r…
lukewilliamboswell Mar 23, 2026
3865d99
Fix UAF, signal handler, and code quality issues in eval test runner
lukewilliamboswell Mar 23, 2026
ba057ed
Fix realloc alignment, remove code duplication, and improve eval test…
lukewilliamboswell Mar 23, 2026
c05b142
Migrate 306 eval tests to parallel runner (524 test cases)
lukewilliamboswell Mar 23, 2026
4fca188
Migrate closure_test.zig eval tests to parallel runner (53 tests)
lukewilliamboswell Mar 23, 2026
b8025cd
Migrate arithmetic_comprehensive_test.zig to parallel runner (226 tests)
lukewilliamboswell Mar 23, 2026
3e213f0
Migrate list_refcount_*.zig eval tests to parallel runner (105 tests)
lukewilliamboswell Mar 23, 2026
ccfacd3
Add inspect_str support and migrate 57 more eval tests to parallel ru…
lukewilliamboswell Mar 23, 2026
f0d8ad9
Add tag union support and migrate remaining eval tests to parallel ru…
lukewilliamboswell Mar 23, 2026
fad4cee
Remove unused buildStructFromFields and buildStructNode functions
lukewilliamboswell Mar 23, 2026
0af9bd2
Replace migration prompt with coverage-driven eval test prompt
lukewilliamboswell Mar 23, 2026
796a15b
Delete eval_test.zig by moving remaining tests to proper homes
lukewilliamboswell Mar 23, 2026
f553274
Fix docs snapshot panics from non-func monotypes in Monomorphize
lukewilliamboswell Mar 23, 2026
b69275e
WIP eval test coverage
lukewilliamboswell Mar 23, 2026
72b166e
Merge origin/main into lir-interpreter
lukewilliamboswell Mar 23, 2026
b39d3f0
Add eval coverage tests for shifts, float/int conversions, typed arit…
lukewilliamboswell Mar 23, 2026
825eacd
Fix seamless slice segfault by replacing manual RocStr/RocList decodi…
lukewilliamboswell Mar 23, 2026
189c142
Add hang watchdog to parallel test runner and more eval tests
lukewilliamboswell Mar 23, 2026
91429a2
Remove unused SKIP_INTERP constant
lukewilliamboswell Mar 23, 2026
db4c44e
fmt
lukewilliamboswell Mar 23, 2026
97b2cf8
Skip cross-def closure snapshots and document investigation findings
lukewilliamboswell Mar 23, 2026
7a47e0e
remove intermediate files
lukewilliamboswell Mar 23, 2026
2280c2b
Fix watchdog for 32-bit targets and crash message free
lukewilliamboswell Mar 23, 2026
4c4866b
Skip U16 minus and rem_by tests that hang on x86_64-linux CI
lukewilliamboswell Mar 23, 2026
ee70ee3
Skip all U8/U16 large-value arithmetic tests (hang on x86_64-linux)
lukewilliamboswell Mar 23, 2026
a26697d
Skip U128 subtraction test that hangs on x86_64-linux CI
lukewilliamboswell Mar 23, 2026
5fa1bf6
Fix cross-def closure evaluation with batch lowering retry
lukewilliamboswell Mar 23, 2026
d2d8f8c
Fix MIR panics triggered by comptime evaluation of incomplete/errored…
lukewilliamboswell Mar 23, 2026
4edac43
Remove roc_target parameter from interpreter pipeline and clean up ev…
lukewilliamboswell Mar 23, 2026
1df42e4
Merge origin/main into lir-interpreter
lukewilliamboswell Mar 23, 2026
7f16289
Harden MIR pipeline against type mismatches and fix crash message leak
lukewilliamboswell Mar 23, 2026
7b4810e
Handle degenerate monotypes in MirToLir instead of panicking
lukewilliamboswell Mar 23, 2026
3c24d1f
Fix interpreter expect, dbg, and refcount operations
lukewilliamboswell Mar 24, 2026
a4cd78c
Add work_stack.zig with WorkItem/Continuation types for stack-safe ev…
lukewilliamboswell Mar 24, 2026
f8aafaf
Convert interpreter bindings from HashMap to flat ArrayList
lukewilliamboswell Mar 24, 2026
d11f18a
Implement stack-safe eval engine with WorkStack/ValueStack architecture
lukewilliamboswell Mar 24, 2026
124bb0c
Wire eval() to stack-safe engine and fix re-entrancy
lukewilliamboswell Mar 24, 2026
3e74e24
Remove 15 dead recursive eval functions replaced by stack-safe engine
lukewilliamboswell Mar 24, 2026
60f6bde
Delete interpreter_layout and interpreter_values modules
lukewilliamboswell Mar 24, 2026
d5f0ce7
Clean up stale references to old CIR interpreter
lukewilliamboswell Mar 24, 2026
e6de43a
Merge remote-tracking branch 'origin/main' into lir-interpreter
lukewilliamboswell Mar 24, 2026
c13bfc2
Remove horizontal separator comments from work_stack.zig
lukewilliamboswell Mar 24, 2026
d5c3311
Add doc comments to pub declarations in work_stack.zig
lukewilliamboswell Mar 24, 2026
c67ee7f
Remove dead code: evalStructAccess, evalTagPayloadAccess, evalCrash, …
lukewilliamboswell Mar 24, 2026
f74bca1
Remove unused variable suppressions and @enumFromInt(0) from work_sta…
lukewilliamboswell Mar 24, 2026
e83ad9c
Delete pointless work_stack size test
lukewilliamboswell Mar 24, 2026
1ae7f2c
Fix double-processing of unwinding boundary continuations in evalStac…
lukewilliamboswell Mar 24, 2026
7dca2d9
Remove unused std import from work_stack.zig
lukewilliamboswell Mar 24, 2026
878ec95
WIP
lukewilliamboswell Mar 24, 2026
2afc88e
Merge main into eval-test-runner
lukewilliamboswell Mar 24, 2026
0675306
Merge eval-test-runner into lir-interpreter
lukewilliamboswell Mar 24, 2026
3f7dd72
Create debugging_backend_bugs.md
lukewilliamboswell Mar 24, 2026
b8e23c3
Fix list operations crashing with refcounted elements (e.g. strings)
lukewilliamboswell Mar 24, 2026
dabc914
Fix type mismatch tests crashing the compiler (9 crashes → 0)
lukewilliamboswell Mar 24, 2026
836633b
Document monomorphization root cause for non-Dec numeric literal bugs
lukewilliamboswell Mar 24, 2026
0fc5299
Remove legacy recursive eval paths (callProcSpec, evalCFStmt)
lukewilliamboswell Mar 24, 2026
18d1237
Clean up stale comments after legacy eval path removal
lukewilliamboswell Mar 24, 2026
9b94acc
fix fmt
Anton-4 Mar 24, 2026
b89ff64
Replace string-based cross-module ident resolution with pre-built ind…
Anton-4 Mar 24, 2026
1c54d3f
Pass --test-filter through to eval test runner
Anton-4 Mar 24, 2026
3f164e7
Unify eval test runner into single path, fix silent backend failures
lukewilliamboswell Mar 24, 2026
07a3a1c
Improve test failure reporting with per-backend detail and expected t…
lukewilliamboswell Mar 24, 2026
d1f8766
Fix WASM backend shift operations on i64 values
lukewilliamboswell Mar 24, 2026
cb1f4cc
Fix dev backend List.concat refcount underflow for string elements
lukewilliamboswell Mar 24, 2026
cda524a
Fix test runner resource leaks on timeout and increase hang threshold
lukewilliamboswell Mar 24, 2026
221c6eb
Replace setjmp/longjmp crash protection with fork isolation for all b…
lukewilliamboswell Mar 24, 2026
643281c
Change F64 equality test from skip to expected type error
lukewilliamboswell Mar 25, 2026
fb979c1
Unskip Str.contains for interpreter/dev and fix test runner watchdog
lukewilliamboswell Mar 25, 2026
348def8
Run eval tests before other test suites to avoid macOS jetsam kills
lukewilliamboswell Mar 25, 2026
508649f
Add eval interpreter coverage tooling with kcov
lukewilliamboswell Mar 25, 2026
70cfa7a
Document eval test location and skip behaviour in coverage guide
lukewilliamboswell Mar 25, 2026
949813f
Reference Builtin.roc in coverage guide for available builtins/syntax
lukewilliamboswell Mar 25, 2026
5ebf6f2
Add 68 eval tests for numeric conversions, list ops, and string inter…
lukewilliamboswell Mar 25, 2026
b965082
Add 62 eval tests to improve interpreter coverage from 48.73% to 51.89%
lukewilliamboswell Mar 25, 2026
7e4e434
Implement I128/U128 shift operations for dev and wasm backends
lukewilliamboswell Mar 25, 2026
36b030f
Fix 11 skipped eval tests: correct conversion method names to use _wr…
lukewilliamboswell Mar 25, 2026
1c8a3c6
Unskip 3 more eval tests: list of typed ints and U128 subtraction
lukewilliamboswell Mar 25, 2026
6252bb9
Fix float-to-int and Dec-to-int conversions: builtin name mismatch + …
lukewilliamboswell Mar 25, 2026
fcdd73f
Provide __multi3/__muloti4 in builtins for wasm32 self-containment
lukewilliamboswell Mar 25, 2026
5d342e4
Add WasmBuiltinsMerger: infrastructure for linking wasm32 builtins in…
lukewilliamboswell Mar 25, 2026
c1f1383
Add detailed implementation plan for wasm relocatable object + builti…
lukewilliamboswell Mar 25, 2026
25e3498
Revert "Add WasmBuiltinsMerger: infrastructure for linking wasm32 bui…
lukewilliamboswell Mar 25, 2026
dec56d3
DRY wasm host functions: delegate to shared builtins instead of reimp…
lukewilliamboswell Mar 25, 2026
582f039
Error on `roc build` for wasm32: not yet supported
lukewilliamboswell Mar 25, 2026
1874e08
Delegate wasm Dec host functions to builtins; document string/list gap
lukewilliamboswell Mar 25, 2026
52293a2
Add WasmRocOps and delegate Dec div/divTrunc to builtins
lukewilliamboswell Mar 25, 2026
6caaf14
Delegate wasm string host functions to shared builtins via translatio…
lukewilliamboswell Mar 25, 2026
ae28a5b
Delegate strSplit, strJoinWith, strWithPrefix to builtins; document l…
lukewilliamboswell Mar 25, 2026
473b1b6
Replace thread pool with fork-based process pool in eval test runner
lukewilliamboswell Mar 25, 2026
787a741
Update TODO_FIX_INTERPRETER_PROMPT with current test status and wasm …
lukewilliamboswell Mar 25, 2026
a25db22
Guard monomorphization dispatch against CIR numeral-default mismatch;…
lukewilliamboswell Mar 25, 2026
cd651cd
Fix numeric type defaulting: keep polymorphic vars for monomorphization
lukewilliamboswell Mar 25, 2026
7fa4292
Fix duplicate error reports in verifyNumericDefaults; update snapshots
lukewilliamboswell Mar 25, 2026
5279d8d
Fix 18 SKIP_ALL eval tests: correct method names and add Dec type suf…
lukewilliamboswell Mar 25, 2026
4cba63b
Pre-load builtins before fork and use arena in backend eval children
lukewilliamboswell Mar 25, 2026
6a246fc
Unskip 35 eval tests: enable interpreter+wasm on formerly dev-only an…
lukewilliamboswell Mar 25, 2026
d6448d2
update snapshots
Anton-4 Mar 25, 2026
da40dc5
Merge branch 'main' of github.com:roc-lang/roc into lir-interpreter
Anton-4 Mar 25, 2026
d50491d
Add parallel CLI test runner and minici timing
lukewilliamboswell Mar 25, 2026
60a544b
Fix test-cli filter plumbing and messaging
lukewilliamboswell Mar 25, 2026
6d353e3
Unify Interpreter API around caller-provided RocOps and fix dbg lowering
lukewilliamboswell Mar 26, 2026
b60ba35
Fix minici lint and tidy violations
lukewilliamboswell Mar 26, 2026
ff774b5
Fix playground wasm32-freestanding build by gating std.debug.print in…
lukewilliamboswell Mar 26, 2026
0cfc8f8
Bind RocOps at Interpreter init instead of per-eval and add emptyHost…
lukewilliamboswell Mar 26, 2026
d5457ab
Fix interpreter ownership leaks causing REPL failures
lukewilliamboswell Mar 26, 2026
7930755
Extract shared test harness from parallel CLI runner
lukewilliamboswell Mar 26, 2026
e86f7ce
Migrate eval runner to shared test harness
lukewilliamboswell Mar 26, 2026
4d60e7a
Reorganize test-cli into independent sub-steps
lukewilliamboswell Mar 26, 2026
c78f54a
Fix shared test harness regressions in arg parsing, stabilization, an…
lukewilliamboswell Mar 26, 2026
1e0d30b
Implement tag union RC and remove interpreter-local ownership workaro…
lukewilliamboswell Mar 26, 2026
d56a2d7
Add dropValue API and enable interpreter leak checking in test helpers
lukewilliamboswell Mar 26, 2026
0f8b60d
Fix 67 interpreter memory leaks in list RC, pattern matching, and Str…
lukewilliamboswell Mar 26, 2026
feb1721
Enable interpreter leak checking across test infrastructure
lukewilliamboswell Mar 26, 2026
68096d8
Fix stack overflow when using dbg on recursive nominal types
lukewilliamboswell Mar 26, 2026
0c542cf
Fix box allocation header mismatch and report failed expects in inter…
lukewilliamboswell Mar 26, 2026
271baa7
Fix monomorphizer combinatorial explosion with per-convergence-loop v…
lukewilliamboswell Mar 26, 2026
a68773f
Fix MIR lowering exponential blowup in lowerDotAccess receiver lowering
lukewilliamboswell Mar 26, 2026
ffc79fb
remove plan
lukewilliamboswell Mar 26, 2026
4ee6fcc
Isolate snapshot backend checks in subprocesses
rtfeldman Mar 26, 2026
4c363f0
Fix stack overflow helper wiring
rtfeldman Mar 26, 2026
345f770
Track dev backend runtime leaks in tests
rtfeldman Mar 26, 2026
3022642
Fix use-after-reallocation in monomorphize finalizeResolvedDirectCall…
lukewilliamboswell Mar 27, 2026
c0bbca7
Fix eval test runner to actually validate expected values
lukewilliamboswell Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
155 changes: 0 additions & 155 deletions .plan
View file
Open in desktop

This file was deleted.

Loading
Loading