Add wasm32 compatibility#49
Conversation
…r on wasm (FIXME)
|
@robertu94 I'd like to push forward with these changes now that they've been cleaned up |
robertu94
left a comment
robertu94
left a comment
There was a problem hiding this comment.
Most of these comments are small.
|
@robertu94 Thank you for the review! I've tried to address all of your comments, but left two unresolved since I need more input from you. |
|
@robertu94 Does this PR need anything else, or can it be merged? Ideally, I'd like to publish the libpressio-rs and numcodecs-pressio crates once this PR is upstream (and ideally ideally there has been a release with these changes so we can point at a release version) |
|
I think it looks good. I want to pull in these changes locally and do some testing to double-check that nothing broke, and I hope to do that soon. It's on my todo list I promise. |
|
@robertu94 What's the status? |
2 participants
This PR allows libpressio to be compiled for wasm32, which is used with the libpressio-rs bindings to compile numcodecs-pressio to numcodecs-wasm-pressio