Conversation
|
Benchmarks should be done in a few days. |
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (88.23%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #2159 +/- ##
==========================================
- Coverage 91.56% 91.52% -0.04%
==========================================
Files 197 198 +1
Lines 10927 10979 +52
Branches 1387 1393 +6
==========================================
+ Hits 10005 10049 +44
- Misses 663 669 +6
- Partials 259 261 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ryanjulian
left a comment
There was a problem hiding this comment.
How are the benchmark results?
krzentner
left a comment
There was a problem hiding this comment.
Nice. This is a pretty clean implementation.
4e708fd to
bf2b104
Compare
|
Currently rerunning some of the benchmarks (some were interrupted), will report back once they're done. |
Closes #1489.