Skip to content

ojdk 25 does not do parallel Install anymore#1

Open
andrlos wants to merge 3 commits intomainfrom
skip25AndUp
Open

ojdk 25 does not do parallel Install anymore#1
andrlos wants to merge 3 commits intomainfrom
skip25AndUp

Conversation

@andrlos
Copy link
Collaborator

@andrlos andrlos commented Mar 4, 2026

skipping test if it should run on jdk25 or newer

andrlos added 2 commits March 4, 2026 17:40
skipping test if it should run on jdk25 or newer
RUNNING=false

if [[ ( x${BUILD_OS_NAME} == xel && ${BUILD_OS_VERSION} > 6 ) || x${BUILD_OS_NAME} == xf ]]; then
if [[ ${JDK_VERSION} -lt 25 ]]; then
Copy link

@judovana judovana Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of old condition is wrong? It hsoudl be

(( x${BUILD_OS_NAME} == xel && ${BUILD_OS_VERSION} > 6 )  && ${JDK_VERSION} -lt 25 ) || x${BUILD_OS_NAME} == xf 

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you plan on running anything on el6 and older??

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can add it to the readme..

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parallel isntalls are at rhel 8+9 on jdk 8-21. Are missing on all jdks in all fedoras. Are missing on jdk25 in both el9 and 10

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that it wont work on el6 and older.. but no point in leaving condition for a system almost as old as I am

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, el7 have paralel installs to.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so: The parallel isntalls are at rhel 7-9 on jdk 8-21. Are missing on all jdks in all fedoras. Are missing on jdk25 in both el9 and 10, are missing on jdk21 in el10

more strict condition, my initiall understanding was wrong
@@ -61,10 +61,21 @@ function run_parallel_test {

RUNNING=false
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls add comment that all fedoras have it removed. As it is missing in conditions, it can be confusing.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise lkooks good now,. TY!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants