Skip to content

Do not crash when there are inconsistent assumptions#523

Open
peterohanley-galois wants to merge 1 commit intorems-project:mainfrom
GaloisInc:errmsg-inconsistent-assumptions
Open

Do not crash when there are inconsistent assumptions#523
peterohanley-galois wants to merge 1 commit intorems-project:mainfrom
GaloisInc:errmsg-inconsistent-assumptions

Conversation

@peterohanley-galois
Copy link
Copy Markdown
Contributor

No description provided.

@peterohanley-galois peterohanley-galois force-pushed the errmsg-inconsistent-assumptions branch from db8a604 to f2d1fd4 Compare April 3, 2026 19:18
@peterohanley-galois peterohanley-galois force-pushed the errmsg-inconsistent-assumptions branch from f2d1fd4 to 47f303a Compare April 3, 2026 21:12
@pqwy
Copy link
Copy Markdown
Contributor

pqwy commented Apr 13, 2026

Is the loss of location information (here) intentional?

@peterohanley-galois
Copy link
Copy Markdown
Contributor Author

Is the loss of location information (here) intentional?

It's how it was reported previously, I just unified the handlers and made them stop asserting. The error is still reported with loc

@pqwy
Copy link
Copy Markdown
Contributor

pqwy commented Apr 13, 2026

loc now carries __LOC__ pointing to a different place, so the two places which were previously distinguishable by location are not distinguishable any longer?

Comment thread lib/resourceInference.ml
@@ -123,20 +141,7 @@ module General = struct
let uiinfo = (situation, request_chain) in
let@ o_re_oarg = resource_request loc uiinfo resource in
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fails with the same loc from here.

@pqwy
Copy link
Copy Markdown
Contributor

pqwy commented Apr 13, 2026

Ah, I mis-read it.

I was wondering why does changing the location of __LOC__ not matter, but that one seems not to be propagated out in any of the cases.

@peterohanley-galois
Copy link
Copy Markdown
Contributor Author

Yes, that's only for the synthesized boolean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants