Conversation
johannah-pik
requested review from
LaviniaBaumstark,
ahagen-pik,
jmuessel and
robertpietzcker
|
@LaviniaBaumstark @tonnrueter do you consider it as necessary that I "executed the automated model tests (make test) after my final commit" for this change? |
…cleanVariableHarmonization
…nah-pik/remind into cleanVariableHarmonization
| # generate transport extended mif | ||
| reporttransport::reportEdgeTransport(edgetOutputDir, | ||
| EDGEToutputPriorHarmonization <-reporttransport::reportEdgeTransport(edgetOutputDir, | ||
| isTransportExtendedReported = TRUE, |
There was a problem hiding this comment.
Thank you @johannah-pik - I find the "double"-reporting pragmatic, and I don't see a more runtime-efficient way to do this. One thing that would improve this a little bit would be not to do the extended reporting, but only isTransportReported.
There was a problem hiding this comment.
Hi @jmuessel, thanks for your feedback :) I am also in favor of keeping the double reporting and the detailed transport data to render our transport compScen.
The reporting itself is not particularly computationally intensive (for what you get).
I meant the double loading of the giant REMIND.mif file for comparison (I am marking that in the code)
There was a problem hiding this comment.
Got it. Then I think we can keep it as is. Thx again!
| mifs <- list.files(".", recursive = FALSE, full.names = TRUE) | ||
| mif <- mifs[grepl(".*withoutPlus\\.mif", mifs)] | ||
| #Select matching variables | ||
| REMINDvars <- as.data.table(read.quitte(mif)) |
There was a problem hiding this comment.
Here we are loading the REMIND.mif just to calculate one additional variable
| scenarioName = scenario, | ||
| gdxPath = file.path(outputdir, "fulldata.gdx"), | ||
| isStored = FALSE, | ||
| isHarmonized = TRUE) |
There was a problem hiding this comment.
Here we are loading it as well to check the harmonization.
I did that before the request of the additional variable.
Maybe putting the test into a seperate function and calling it in reporting.R would be more elegant.
Anyway - that can be refined later on :)
you clone your REMIND branch with all your changes into a folder on the cluster, and then simply type |
robertpietzcker
left a comment
robertpietzcker
left a comment
There was a problem hiding this comment.
I can't comment on the code, but if it works, thanks a lot for implementing this!
|
yes, |
…cleanVariableHarmonization
4 participants
Purpose of this PR
Include REMIND/EDGE-T variable harmonization, which is described in detail here:
pik-piam/reporttransport#21
Please explain your PR here.
Change edgeTransport reporting calls and include ratio of "FE|Transport" (with bunkers) EDGE-T to REMIND before harmonization to the REMIND.mif as an indicator
Type of change
Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.
Parts concerned
Impact
Checklist
Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge.
make test) after my final commit and all tests pass (FAIL 0)remind2if and where it was neededforbiddenColumnNamesin readCheckScenarioConfig.R in case the PR leads to deprecated switchesCHANGELOG.mdcorrectly (added, changed, fixed, removed, input data/calibration)Further information (optional)