Skip to content

DEV: (cmds) More JSON commands clarifications#3012

Merged
dwdougherty merged 13 commits intomainfrom
LiorKogan-patch-1
Apr 10, 2026
Merged

DEV: (cmds) More JSON commands clarifications#3012
dwdougherty merged 13 commits intomainfrom
LiorKogan-patch-1

Conversation

@LiorKogan
Copy link
Copy Markdown
Member

@LiorKogan LiorKogan commented Apr 10, 2026

Updated the description and summary to clarify that the command returns the length of JSON strings at multiple paths matching a given path expression.


Note

Low Risk
Docs-only wording updates that clarify JSONPath vs legacy path behavior and expected replies; no runtime or API behavior changes.

Overview
Clarifies JSON.OBJKEYS and JSON.OBJLEN descriptions/summaries to state they operate on objects at paths matching a path expression.

Rewrites JSON.STRLEN and JSON.STRAPPEND docs to emphasize multi-match behavior, explicitly document JSONPath vs legacy path defaults, and detail per-mode return/error semantics. Also refreshes argument descriptions and cross-links (see also/related topics) to point to JSONPath and related JSON string/array commands.

Reviewed by Cursor Bugbot for commit 9bc3cab. Bugbot is set up for automated code reviews on this repo. Configure here.

Updated the description and summary to clarify that the command returns the length of JSON strings at multiple paths matching a given path expression.
@jit-ci
Copy link
Copy Markdown

jit-ci bot commented Apr 10, 2026

🛡️ Jit Security Scan Results

CRITICAL HIGH MEDIUM

✅ No security findings were detected in this PR


Security scan by Jit

Updated the description and summary to clarify that the command appends a string to JSON strings at paths matching a given path expression.
@LiorKogan LiorKogan changed the title Clarify description and summary for JSON.STRLEN JSON.STRLEN and JSON.STRAPPEND: clarify description and summary Apr 10, 2026
@LiorKogan LiorKogan requested a review from dwdougherty April 10, 2026 12:51
@LiorKogan LiorKogan changed the title JSON.STRLEN and JSON.STRAPPEND: clarify description and summary More JSON commands clarifications Apr 10, 2026
Copy link
Copy Markdown
Collaborator

@dwdougherty dwdougherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of items for you to check.

@dwdougherty dwdougherty self-assigned this Apr 10, 2026
@dwdougherty dwdougherty added cmds oss Redis Open Source labels Apr 10, 2026
@dwdougherty dwdougherty changed the title More JSON commands clarifications DEV: (cmds) More JSON commands clarifications Apr 10, 2026
@LiorKogan LiorKogan requested a review from dwdougherty April 10, 2026 17:04
@dwdougherty dwdougherty dismissed their stale review April 10, 2026 18:41

All suggestions applied.

Co-authored-by: David Dougherty <david.dougherty@redis.com>
@dwdougherty
Copy link
Copy Markdown
Collaborator

Thank you, @LiorKogan!

@dwdougherty dwdougherty merged commit 25323bc into main Apr 10, 2026
47 checks passed
@dwdougherty dwdougherty deleted the LiorKogan-patch-1 branch April 10, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cmds oss Redis Open Source

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants