Conversation
Contributor
Contributor
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
dwdougherty
approved these changes
Apr 6, 2026
Collaborator
dwdougherty
left a comment
dwdougherty
left a comment
There was a problem hiding this comment.
Just the one suggestion. Otherwise, LGTM.
content/operate/rs/databases/memory-performance/eviction-policy.md
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Low risk: documentation-only changes clarifying eviction behavior and thresholds, with no runtime code impact.
Overview
Clarifies eviction behavior to emphasize per-shard memory tracking in clustered databases, including that uneven key distribution can trigger eviction on some shards before the overall database appears full.
Rewrites the Active-Active eviction section to explicitly state that the 80% eviction threshold is per-shard, and adds concise bullet points describing eviction rate increases, anti-over-eviction heuristics (80% vs 100%), and shard
maxmemoryadjustments; also includes minor wording/formatting cleanups (e.g., Auto Tiering note, out-of-memory casing).Reviewed by Cursor Bugbot for commit 572c672. Bugbot is set up for automated code reviews on this repo. Configure here.