Skip to content

RS: Added more details to create CA-signed certs#2965

Open
rrelledge wants to merge 6 commits intomainfrom
DOC-6065
Open

RS: Added more details to create CA-signed certs#2965
rrelledge wants to merge 6 commits intomainfrom
DOC-6065

Conversation

@rrelledge
Copy link
Copy Markdown
Collaborator

@rrelledge rrelledge commented Mar 31, 2026

Note

Low Risk
Primarily documentation and small CSS tweaks; low risk aside from potential confusion if any certificate requirements are misstated.

Overview
Documentation update: Greatly expands create-certificates.md to spell out CA-signed certificate requirements (EKU/key usage, SAN DNS patterns, key size/validity, SHA-1 warning), and adds end-to-end procedures for OpenSSL and Windows AD CS (CSR submission, chain assembly, export/convert to PEM), plus new sections for validation commands, installation steps, and common TLS troubleshooting.

Styling: Updates index.css to apply distinct list-style types for nested ordered lists in .prose (decimal → lower-alpha → lower-roman → decimal) to improve readability of multi-level steps.

Written by Cursor Bugbot for commit 2865968. This will update automatically on new commits. Configure here.

@rrelledge rrelledge requested review from a team and yoavredis March 31, 2026 21:29
@rrelledge rrelledge self-assigned this Mar 31, 2026
@rrelledge rrelledge added the rs Redis Software label Mar 31, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 31, 2026

DOC-6065

@github-actions
Copy link
Copy Markdown
Contributor

@jit-ci
Copy link
Copy Markdown

jit-ci bot commented Mar 31, 2026

🛡️ Jit Security Scan Results

CRITICAL HIGH MEDIUM

✅ No security findings were detected in this PR


Security scan by Jit

Copy link
Copy Markdown
Contributor

@andy-stark-redis andy-stark-redis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion that might improve the clarity of the lists a bit, but otherwise language and links LGTM.


1. Export the certificate with the private key:

1. Select **Yes, export the private key**.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a thought, but maybe consider using unordered lists for these sublists? I know the sublists still represent ordered sequences of instructions, but the numbering starts looking complicated for a procedure with many steps and sub-steps, like this one.

An alternative might be to see if you can use lettered lists for sublists like these. I don't think Markdown supports them directly, but you might be able to do it with some CSS.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andy-stark-redis Thank you! I updated the CSS to use lettered sublists. That's how our old docs site worked anyway, so I was happy to try and change it. Does the updated staged preview seem more readable with the lettered sublists?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rrelledge Yeah, that's exactly what I was thinking, thanks. Looks great and everyone will benefit from this going forward :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rs Redis Software

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants