Open
Conversation
Merging this PR will improve performance by 11%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | most_significant_bits/4096/4096 |
28.9 µs | 26.1 µs | +11% |
| ⚡ | to/f32/4096 |
29.1 µs | 26.3 µs | +10.77% |
| ⚡ | to/f64/4096 |
29.2 µs | 26.4 µs | +10.61% |
Comparing DaniPopes:dani/fix-easy-todos (96c32be) with main (4af858c)
- perf(cmp): use counter-based const_eq for better x86_64 codegen - docs(gcd): fix incorrect panic doc on Matrix::from_u64 - chore: remove stale TODO suffix from missing_docs allow - chore: justify clippy::similar_names allow with paper reference
DaniPopes
force-pushed
the
dani/fix-easy-todos
branch
from
7c48e46 to
96c32be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #545 -
const_eqcounter-based implementation for ~200 cycle improvement on x86_64Closes #349 - Fix incorrect panic doc on
Matrix::from_u64(saidr0 < r1, should ber1 > r0)Closes #323 - Remove stale
// TODO: document algorithmsfrom#