MacOS build enhancements, support for LIRC IR on MacOS.#245
Open
wilson wants to merge 5 commits intoralph-irving:masterfrom
Open
MacOS build enhancements, support for LIRC IR on MacOS.#245wilson wants to merge 5 commits intoralph-irving:masterfrom
wilson wants to merge 5 commits intoralph-irving:masterfrom
Conversation
Also adds a number of default build options, based on what seemed plausible via homebrew circa 2025.
Author
|
In case anyone is interested, here's a |
ralph-irving
requested changes
Apr 21, 2026
Owner
ralph-irving
left a comment
There was a problem hiding this comment.
Would you separate this commit into a separate PR?
ralph-irving
requested changes
Apr 21, 2026
Owner
ralph-irving
left a comment
There was a problem hiding this comment.
Would you separate this commit into a separate PR as well?
Owner
|
I'd like to include your changes for the MacOS builds, however these changes break my current build flow for the mac. Would you merge all the Makefile.osx changes in this PR into a new and different Makefile.???? Maybe Makefile.macos. Then I could migrate my build process to use the new makefile when time permits, while you and others can use it immediately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just some things I ended up doing to my local copy, I thought I'd see if you were interested in incorporating them.
This all started when I learned that the release builds for MacOS don't enable many of the build flags by default.
My local copy is now happy looking like this:
At the moment a working LIRC on MacOS requires some patches I've done, I'm separately working on contributing those back to LIRC upstream. Because of that, this checks to see if LIRC is installed before enabling that build option.