memcache: reject oversized value lengths in protocol parser#315
Merged
memcache: reject oversized value lengths in protocol parser#315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
bytesbefore using it to drive reads into the fixed per-client buffer.Description
protocol_handle(inmemcache/protocol.c) to reject write-like commands whenbytes > (MCSDB_MAX_BUFFER - 2)and returnCLIENT_ERROR data too biginstead of switching to mode 1.Testing
make -C src libsdb.a, which succeeded.make -C memcache -j4, but the memcache build failed in this environment due tocmds.hgeneration/linkage issues unrelated to this patch (undefined reference tosdb_strdup), so the final memcache binary could not be produced here.Codex Task