Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates frontend dependencies and performs small API/type cleanups across the isomorphic hooks, UI components, localization templates, and an auto-generated API client.
Changes:
- Bumped several dependencies (TanStack Query, Mantine, Lingui, hey-api/openapi-ts, etc.) and updated the lockfile.
- Improved type structure and hook return stability (memoized return objects, extracted
NowState, addedonValuesChangeplumbing touseForm). - Adjusted templated app description strings used in metadata and localization templates.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/src/isomorphic/state/types.ts | Extracts NowState for reuse and simplifies State.now typing. |
| src/src/isomorphic/generic/hooks/use-hydrated/main.ts | Memoizes hook return object for stable reference. |
| src/src/isomorphic/core/hooks/use-form/types.ts | Adds onValuesChange type and exposes it on UseFormInput. |
| src/src/isomorphic/core/hooks/use-form/main.ts | Passes onValuesChange through to Mantine form config. |
| src/src/common/localization/locales/pl.po.jinja | Switches layout description msgid/msgstr to templated {{ description }}. |
| src/src/common/localization/locales/en.po.jinja | Switches layout description msgid/msgstr to templated {{ description }}. |
| src/src/common/core/components/generic/loading-widget/types.ts | Replaces object input type with a typed type?: LoaderProps["type"]. |
| src/src/common/core/components/generic/loading-widget/main.tsx | Allows configuring Mantine <Loader> type via props. |
| src/src/common/apis/icanhazdadjoke/core/bodySerializer.ts | Tightens serializer types to unknown, with casts in implementations. |
| src/src/common/apis/icanhazdadjoke/clnt.ts | Narrows CreateClientConfig to sync return type. |
| src/src/common/apis/icanhazdadjoke/client/types.ts | Narrows CreateClientConfig to sync return type. |
| src/src/common/apis/icanhazdadjoke/client/clnt.ts | Adjusts serializedBody typing/casts and wraps buildUrl to include base config. |
| src/src/client/generic/hooks/use-now/main.ts | Memoizes hook return object for stable reference. |
| src/src/app/global-error.tsx.jinja | Uses templated {{ description }} for meta description. |
| src/src/app/(root)/layout.tsx.jinja | Uses templated {{ description }} for localized description message. |
| src/package.json.jinja | Bumps dependency versions. |
| src/package-lock.json.jinja | Updates lockfile entries to match new dependency versions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.