Add Clang analysis stage to CI and implement analysis script#105
Merged
luismiguensfernandez merged 2 commits intomasterfrom Mar 20, 2026
Merged
Add Clang analysis stage to CI and implement analysis script#105luismiguensfernandez merged 2 commits intomasterfrom
luismiguensfernandez merged 2 commits intomasterfrom
Conversation
Member
luismiguensfernandez
commented
Mar 19, 2026
luismiguensfernandez
commented
- Introduced a new CI stage for running Clang analysis on Linux.
- Added a script for performing Clang static analysis and clang-tidy checks.
- Updated CanDeviceConfiguration to maintain consistency in string conversion.
- Introduced a new CI stage for running Clang analysis on Linux. - Added a script for performing Clang static analysis and clang-tidy checks. - Updated CanDeviceConfiguration to maintain consistency in string conversion.
There was a problem hiding this comment.
Pull request overview
This PR adds a Linux CI job to run Clang Static Analyzer and clang-tidy, alongside a small update to CanDeviceConfiguration::to_string() to keep field handling consistent.
Changes:
- Added a GitLab CI job to run Clang analysis on Linux.
- Introduced
ci/run-clang-analysis-linux.shto configure/build with Clang, runscan-build, and runclang-tidy. - Updated
CanDeviceConfiguration::to_string()to setfirst = falseconsistently for the last optional field (with a linter suppression comment).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/main/CanDeviceConfiguration.cpp |
Adds a NOLINT-annotated assignment for consistency in string formatting logic. |
ci/run-clang-analysis-linux.sh |
New analysis script orchestrating CMake build, scan-build reporting, and clang-tidy. |
ci/gitlab/normal.yml |
Adds a Linux CI job that installs Clang tooling and runs the analysis script. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.