Cc 17 windows systec vendor by parasxos · Pull Request #102 · quasar-team/CanModule

parasxos · 2026-02-26T15:09:12Z

No description provided.

Copilot

Pull request overview

This PR adds Windows support for the Systec USB-CANmodul vendor to the CAN module library. It introduces a new vendor implementation that uses the Systec Windows DLL (USBCAN64.lib/dll) to communicate with Systec USB-CAN hardware on Windows platforms, complementing the existing Linux SocketCAN Systec implementation.

Changes:

Added Windows-specific Systec vendor implementation with receive thread handling
Integrated Systec vendor into device factory with Windows platform guards
Configured CMake build system to include Systec headers and libraries on Windows

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 19 comments.

Show a summary per file

File	Description
src/main/CanVendorSystec.cpp	Core implementation of Windows Systec vendor with USB-CAN API integration
src/include/CanVendorSystec.h	Header defining CanVendorSystec class with Windows threading primitives
src/main/CanDevice.cpp	Added conditional compilation to register Systec vendor on Windows
CMakeLists.txt	Added Systec source files to Windows build configuration
cmake/systec.cmake	CMake configuration for Systec USB-CANmodul library paths

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/main/CanVendorSystec.cpp

CMakeLists.txt

src/main/CanVendorSystec.cpp

cmake/systec.cmake

luismiguensfernandez · 2026-02-27T09:17:09Z

Dear @parasxos ,

Currently, the project no longer compiles. Besides all the noise from the copilot (with a significant amount of them being relevant), I see two big points (I did not enter into details of the implementation yet):

To join the thread, you seem to be using WaitForSingleObject, which is Windows-specific, but at the same time, you use the standard library (e.g., std::mutex). Is there any constraint from Systec that forces you to use the Windows API, I think it is cleaner to use the standard library always.
I see no testing at all. Please create some testing. You could base your implementation on the existing Anagate tests: (https://github.com/quasar-team/CanModule/blob/master/test/python/test_anagate.py) and remove/add everything you consider relevant.
We will need a mini-PC and a Systec device to perform the tests automatically; I will need to check in the lab, as we could reuse one, if it supports Windows 11, but we still need a device dedicated to the pipeline, for example: https://phytools.com/products/sys-tec-usb-canmodul2-dual-can-opto-isolated, As far as I know, we only have a small PEAK around the lab.
We were in discussions with Anagate to provide a .lib that we could compile statically, and not a placeholder for an external DLL, as Ben and I would like to avoid the need to redistribute DLLs with the OPC Servers. Do you know if that is possible with Systec? In Linux, we already link statically, so we don't need to redistribute any anagate*.so
Out of curiosity, who is requesting Systec on Windows --- last time I asked, I was met with absolute silence, and Ben never included Systec/Windows support in any of the OPC UA Servers

Thanks and regards,

Luis

jsouter · 2026-02-27T10:26:06Z

Currently, the project no longer compiles.

I have some changes on my local environment which provide the necessary header and library paths to compile, but with the expectation that USBCAN-modul Utility Disk is already installed, I am looking into ways to install it through cmake though I haven't yet figured out how to do this non-graphically.

Is there any constraint from Systec that forces you to use the Windows API, I think it is cleaner to use the standard library always.

I agree and will investigate, largely this code is adapted from an older branch of CanModule

We were in discussions with Anagate to provide a .lib that we could compile statically, and not a placeholder for an external DLL, as Ben and I would like to avoid the need to redistribute DLLs with the OPC Servers. Do you know if that is possible with Systec? In Linux, we already link statically, so we don't need to redistribute any anagate*.so

I'm not aware of a version of the utility that comes with a static build but I will look into it

use actual systec error code names for diagnostics.state

small cleanups

luismiguensfernandez

Hi, thanks for your changes. I scan a bit, and I have some comments

src/include/CanDiagnostics.h

src/main/CanVendorSystec.cpp

luismiguensfernandez · 2026-03-20T16:34:43Z

CMakeLists.txt

    file(COPY "${anagate_SOURCE_DIR}/Win64/AnaGateCan64.dll"
         DESTINATION "${CMAKE_BINARY_DIR}/Release")
+
+    if ("${CANMODULE_BUILD_SYSTEC_WINDOWS}" STREQUAL ON)


Is systec planned to be supported also in the power supplies and/or several OPC Servers? or is it only a single-case? The answer will tell us if having a variable to activate that part of the build is good or bad idea.

src/include/CanVendorSystec.h

test/python/test_systec.py

luismiguensfernandez · 2026-03-20T16:44:57Z

test/python/test_systec.py

+#     reason="This test module is only for Windows environments.",
+# )
+
+pytestmark = pytest.mark.skipif(


If your activities are planned to be merged into the master, we will need to set up the machine and a 2-port system in our lab.

src/main/CanVendorSystec.cpp

* parse bus_number in systec * update uptime comment * use string_view for systec error message

… systec register callback for connect control add error messages to log_entries in diagnostics

parasxos requested review from Copilot and luismiguensfernandez February 26, 2026 15:09

Copilot started reviewing on behalf of parasxos February 26, 2026 15:09 View session

Copilot AI reviewed Feb 26, 2026

View reviewed changes

luismiguensfernandez requested a review from ben-farnham February 27, 2026 09:19

jsouter force-pushed the CC-17_Windows-systec-vendor branch from 86b7d2a to 14dcce4 Compare March 17, 2026 10:01

jsouter added 13 commits March 17, 2026 13:30

Create outline of build for CanVendorSystec

1abe999

Outline of Systec implementation for Windows

caf8377

use switch case to handle systec read responses

6440de5

reconnect systec on a failed send

df040c4

use actual systec error code names for diagnostics.state

fix header guard for CanVendorSystec

e89d908

use std::copy to copy Systec can message data to CanFrame

9eba564

small cleanups

87ddd7d

renames, cleanups, reorderings

3a8298c

fix whitespace issue with warning messages for Systec vendor

dbc8a1e

avoid std::copy by initializing vector with data directly

8517d00

use lock guards on Systec handle map access

b9179c7

small cleanups

use snake_case in CanVendorSystec

e9c11b5

replace Windows specific thread calls with std library calls

a9cf432

jsouter force-pushed the CC-17_Windows-systec-vendor branch from 14dcce4 to 8d1624b Compare March 17, 2026 12:31

jsouter added 8 commits March 17, 2026 15:36

don't copy beyond m_bDLC into Systec data vector

93fd7c5

remove comments copies from STCanScan.cpp

ebab3d2

use fallthrough attributes

540c026

Log send errors in systec and use fallthrough attributes

4850aff

only join systec thread if joinable

70f52a8

switch case formatting

88c9561

convert indentation to spaces

a94c576

remove inline from handle map, make error text function a member method

74ee911

jsouter added 5 commits March 18, 2026 11:40

move reconnect_channel to new method

ae0b19d

remove erroneous FATAL_ERROR from systec.cmake message

18d14d7

remove check on message length in systec vendor_send

4af4598

Add WIP systec test for pcaticswin11

17f4cc7

update test_systec for ELMB id 15

78178bd

luismiguensfernandez reviewed Mar 20, 2026

View reviewed changes

jsouter added 20 commits March 23, 2026 10:35

implement suggestions from review

7755662

* parse bus_number in systec * update uptime comment * use string_view for systec error message

Use descriptive error messages for systec status in diagnostics.state

5fc4c1e

fixes for test_systec

eba8463

throw in systec if invalid bitrate specified

24cf1c9

wrap init_can_port in try block

8b0e775

delay adding CanVendorSystec to port to vendor map

f2b84aa

Only call deinit on nonzero handles, clean up some logging messages

9fc556d

Improve logging for error messages

38d9398

Use std::optional for systec handles, avoid use of [] accessor

af2f3f0

use convenience template to log error messages for all ucan calls

389eb41

remove reconnect_channel

7a7b349

Log status error messages and add to log_entries

826cde5

fix broken if

f055593

move lock_guard out of deinit_channel to prevent double lock acquisition

3b2079e

return early from vendor_diagnostics on error

d903c0d

add config option to deinit both channels when vendor_close called on…

23d0853

… systec register callback for connect control add error messages to log_entries in diagnostics

add systec to canmodule-utils.py on windows

61aa60a

build systec dependency from zip file installer\

205159f

black format python files

f55351a

cpplint fixes

f07c9cd

jsouter force-pushed the CC-17_Windows-systec-vendor branch 2 times, most recently from ab8e721 to 9362dba Compare April 8, 2026 12:03

clang-format on CanVendorSystec

b53784c

jsouter force-pushed the CC-17_Windows-systec-vendor branch from 4d93302 to b53784c Compare April 8, 2026 12:21

Conversation

parasxos commented Feb 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

luismiguensfernandez commented Feb 27, 2026

Uh oh!

jsouter commented Feb 27, 2026

Uh oh!

luismiguensfernandez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

luismiguensfernandez Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

luismiguensfernandez Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants